As per @file is not required for classes, interfaces and traits, we need to remove the @file documentation tag.

@file is still required in other files.

Remaining tasks

  1. Write a patch
  2. Write change records
  3. Review and feedback
  4. RTBC and feedback
  5. Commit
  6. Release - released in 8.0.0-alpha3
CommentFileSizeAuthor
elasticsearch_connector8.x-2.x.patch4.31 KBthandavapati

Issue fork elasticsearch_connector-2764797

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Thandava Krishna Pati created an issue. See original summary.

lachezar.valchev’s picture

lachezar.valchev commented
Status: Needs review » Needs work

Hi,

The patch did not apply clean against the latest code base.

Error message: 

Checking patch src/Plugin/search_api/backend/SearchApiElasticsearchBackend.php...
error: while searching for:
<?php

/**
 * @file
 * Contains the SearchApiElasticsearchBackend object.
 *
 * TODO: Check for dependencies and remove them in order to properly test the code.
 */


error: patch failed: src/Plugin/search_api/backend/SearchApiElasticsearchBackend.php:1
error: src/Plugin/search_api/backend/SearchApiElasticsearchBackend.php: patch does not apply
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

The 8.x-2.x branch is no longer supported by the module maintainers.

The unnecessary @file annotations have been removed from the 8.0.x version of the module.

There is one left in the 8.x-7.x branch.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Version: 8.x-2.x-dev » 8.x-7.x-dev

mparker17 opened merge request !64

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Assigned: thandavapati » Unassigned
Status: Needs work » Needs review

I didn't use the previous patch as a basis for the code in the merge request (it was too far out-of-date).

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Category: Task » Feature request
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: @ file doc annotation removed » @file is not required for classes, interfaces and traits
Issue summary: View changes

sokru made their first commit to this issue’s fork.

  • sokru committed a8889b3c on 8.x-7.x authored by mparker17 
    Issue #2764797 by mparker17, ThandavaPati: @file is not required for...
sokru’s picture

sokru commented
Category: Feature request » Task
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Note this was released in 8.0.0-alpha3

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

(copy-paste error)