Follow-up to #2642612: Create Entity Lookup & Generate process Base plugins

We need tests for the entity_lookup and entity_generate plugins.

CommentFileSizeAuthor
#11 2760443-11.patch9.29 KBheddn
#11 interdiff_5-11.txt8.12 KBheddn
#5 interdiff_2-5.txt6.83 KBheddn
#5 tests_for_entity-2760443-5.patch5.34 KBheddn
#2 tests_for_entity-2760443-2.patch6.83 KBheddn

Comments

mikeryan created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new tests_for_entity-2760443-2.patch6.83 KB

I created the beast, it is only fitting I provide even the most basic of tests.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Related issues: +#2826636: Add non basic tests for entity lookup/generate plugins

I've added #2826636: Add non basic tests for entity lookup/generate plugins so we can start adding some more complex tests. Let's get a simple test case in first and start adding to that base.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Needs work
Issue tags: -Needs tests 
  1. +++ b/tests/modules/migrate_plus_migration_test/migrate_plus_migration_test.info.yml
@@ -0,0 +1,9 @@
+ - entity_reference_revisions

    Copypasta from an ERR test? 

  2. +++ b/tests/modules/migrate_plus_migration_test/migration_templates/migrate_plus_migration_test.yml
@@ -0,0 +1,17 @@
+  plugin: migrate_plus_dummy

    We could use embedded_data and avoid creating a custom source plugin. For that matter, we could create the migration definition as an array within the test and avoid having a test module at all. 

  3. +++ b/tests/src/Kernel/Plugin/migrate/process/EntityGenerateTest.php
@@ -0,0 +1,151 @@
+ * Tests the migration plugin.

    s/migration/entity_generate/ 

+++ b/tests/src/Kernel/Plugin/migrate/process/EntityGenerateTest.php
@@ -0,0 +1,151 @@
+ * @group entity_reference_revisions

More ERR copypasta, I assume.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new tests_for_entity-2760443-5.patch5.34 KB
new interdiff_2-5.txt6.83 KB
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
james.williams’s picture

james.williams
Location Coventry, UK
commented

This is working for me, what's left to do here? The follow-up #2826636: Add non basic tests for entity lookup/generate plugins can cover edge cases (such as #2787219: Entity lookup plugin not able to guess config for entity types without bundle perhaps), so maybe the latest patch here can be committed?

heddn’s picture

heddn
Primary language English
Location Illinois
commented

@james.williams all we are looking for is RTBC. As a first step.

james.williams’s picture

james.williams
Location Coventry, UK
commented
Status: Needs review » Reviewed & tested by the community

Ah ok! I thought there might have been some further work required. As for the tests, they look like a good first step to me, just to show it the basic functionality works. I could well have missed something, but I'd be confident enough to say RTBC.

james.williams’s picture

james.williams
Location Coventry, UK
commented
Status: Reviewed & tested by the community » Needs work

Oh actually ... gosh how many times do you think of something just after pressing submit ... this test covers creating new entities, but not updating existing ones.

We currently test entity_generate for two rows, let's make one match an existing entity to show that gets updated (e.g. rather than created as a duplicate).

And then can we add another field to use entity_lookup on similarly - to match one existing term to get updated, and another that won't match that will therefore get passed over?

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_5-11.txt8.12 KB
new 2760443-11.patch9.29 KB

I think this addresses the comments in #10.

Status: Needs review » Needs work

The last submitted patch, 11: 2760443-11.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review

Wrong branch selected. Tests now pass.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Baltimore2017

  • mikeryan committed 586c617 on 8.x-3.x authored by heddn 
    Issue #2760443 by heddn: Tests for entity lookup/generate plugins
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Fixed

Committed, thanks!

  • mikeryan committed 586c617 on 8.x-4.x authored by heddn 
    Issue #2760443 by heddn: Tests for entity lookup/generate plugins

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.