Follow-up to #2575847: Remove request policy attribute from dynamic page cache subscriber

Problem/Motivation

The fix in #2575847: Remove request policy attribute from dynamic page cache subscriber was correct, but it forgot to update one comment.

Proposed resolution

Update that comment.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2759247-2.patch1.2 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
Issue tags: +Documentation
FileSize
2759247-2.patch1.2 KB
Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

RTBC - looks good to me.

  • xjm committed 473d830 on 8.2.x 
    Issue #2759247 by Wim Leers: Request attribute removed from...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.2.x-dev » 8.1.x-dev

Committed 473d830 and pushed to 8.2.x. I also committed it to 8.1.x because it seemed to apply there as well given #2575847: Remove request policy attribute from dynamic page cache subscriber was an 8.1.x issue. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

  • xjm committed 4eda8b9 on 8.1.x 
    Issue #2759247 by Wim Leers: Request attribute removed from...

  • xjm committed 473d830 on 8.3.x 
    Issue #2759247 by Wim Leers: Request attribute removed from...

  • xjm committed 473d830 on 8.3.x 
    Issue #2759247 by Wim Leers: Request attribute removed from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.