Closed (duplicate)
Project:
Services
Version:
8.x-4.0-alpha4
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Jul 2016 at 13:07 UTC
Updated:
30 May 2021 at 20:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rajeshwari10 commentedReplaced entityManager with entityTyepManager.
Comment #4
rajeshwari10 commentedComment #5
rajeshwari10 commentedComment #7
rajeshwari10 commentedDont know what is causing CI error.
Please review.
Comment #8
kylebrowning commentedFailing cause we have no tests written.
13:28:22 ERROR: No valid tests were specified.Whats this benefit of this change?
Comment #9
rajeshwari10 commented@kylebrowning
entityManager is deprecated so we need to remove it from code base as said in
https://api.drupal.org/api/drupal/core!lib!Drupal.php/function/Drupal%3A...
I just replaced it with entityTypeManager.
Comment #10
kylebrowning commentedComment #11
kylebrowning commentedComment #12
nicola85 commentedThere is no property 'entityTypeManager' in the class Drupal\ctools\Plugin\Deriver\EntityDeriverBase
Comment #13
rajeshwari10 commented@nicola85,
For entityTypeManager property i have added Drupa\Core\Entity\EntityTpyeManagerInterface.
Comment #14
kylebrowning commentedComment #15
therealssj commentedI still get the same error as pointed out by @nicolas85.
Even if Drupa\Core\Entity\EntityTpyeManagerInterface. has been used I don't see it getting injected anywhere.
If we take a look at Drupal\ctools\Plugin\Deriver\EntityDeriverBase
It still utilizes \Drupal\Core\Entity\EntityManagerInterface
So unless ctools is updated this commit will not work.
Comment #16
kylebrowning commentedLooks like even with most up to date ctools, this still breaks.
Comment #17
kylebrowning commentedIts also now a bug since we introduced a breaking commit.
Comment #18
therealssj commentedI have posted a patch in ctools for this https://www.drupal.org/node/2761717
If that doesn't get merged anytime soon, one other way to fix this would be to replace
$this->entityTypeManagerwith\Drupal::entityTypeManagerthough this is obviously not a good way to fix this.Comment #19
lahoosascoots commentedIn all the derivers we just need to change $this->entityTypeManager back to $this->entityManager in all instances. The parent class EntityDeriverBase still uses entityManager as the property name. Once ctools commits the above issue we can switch it.
Comment #20
kylebrowning commentedI think this is a just a task, since everything works still.
Comment #22
jcnventuraThis was done as part of the Drupal 9 readiness in #3154535: Drupal 9