To ease the creation of tests that cover entity translations and revisions we should swap the entity type entity_test for entity_test_mulrev_changed.

Everywhere we use the entity_test entity type, we should change that entity to entity_test_mulrev_changed

CommentFileSizeAuthor
#12 2758475_entity_test_mulrev_changed-M.patch44.21 KBmkalkbrenner
#8 2758475_entity_test_mulrev_changed-8.patch48.75 KBmkalkbrenner
#8 6-8-interdiff.txt596 bytesmkalkbrenner
#6 2758475_entity_test_mulrev_changed-6.patch48.25 KBmkalkbrenner
#4 2758475_entity_test_mulrev_changed.patch41.69 KBmkalkbrenner

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Title: Replace entity_test by entity_test_mulrev_changed throuout kernel tests » Replace entity_test by entity_test_mulrev_changed throughout kernel tests
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue summary: View changes
Issue tags: +Novice

Tagging as novice issue.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Active » Needs review
StatusFileSize
new 2758475_entity_test_mulrev_changed.patch41.69 KB

Locally all kernel tests of search_api and search_api_solr are passing. Let's see what happens on Drupal CI.

Status: Needs review » Needs work

The last submitted patch, 4: 2758475_entity_test_mulrev_changed.patch, failed testing.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 2758475_entity_test_mulrev_changed-6.patch48.25 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2758475_entity_test_mulrev_changed-6.patch, failed testing.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 6-8-interdiff.txt596 bytes
new 2758475_entity_test_mulrev_changed-8.patch48.75 KB
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Parent issue: » #2755869: Implement Language Fallback on Solr Index Level
cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

@mkalkbrenner, can you make the patch again with git diff -M? So it's easier to see what the actual differences are. A quick review from me didn't trigger any red flags, so overall I'm +1 to this.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2758475_entity_test_mulrev_changed-M.patch44.21 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

So much better! Woo

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Yes, looks good, thanks!
Committed.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Great! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.