Currently you need the administer site configuration permission to administer this module.

That permission is very powerful and is generally given to very few users so it is not ideal for use with this module, which is more the domain of a higher level content editor or low level site builder type role.

It is especially annoying to have to have a full site admin edit the block of content at the top of the site map.

This would also need an update script to assign the new permission to all roles that currently have the administer site configuration role.

CommentFileSizeAuthor
#15 After.png9.74 KBrenatog
#15 Before.png17.23 KBrenatog
#13 After.png10.13 KBrenatog
#13 Before.png17.84 KBrenatog
#12 site_map-add_administration-2756765-12.patch1.8 KBpareshpatel
#10 site_map-add_administration-2756765-10.patch1.75 KBpareshpatel
#8 site_map-add_administration_permission-2756765-8.patch1.2 KBsagar ramgade
#5 sitemap-add_administration_permission-2756765-5.patch788 bytessagar ramgade
#3 sitemap_permission-2756765-1.patch371 bytespareshpatel

Comments

rooby created an issue. See original summary.

pareshpatel’s picture

pareshpatel commented
Assigned: Unassigned » pareshpatel
pareshpatel’s picture

pareshpatel commented
Assigned: pareshpatel » Unassigned
Status: Active » Needs review
StatusFileSize
new sitemap_permission-2756765-1.patch371 bytes

Please find the attached patch for the same.

rooby’s picture

rooby commented
Status: Needs review » Needs work

Thanks for the patch.

+++ b/site_map.module
@@ -16,6 +16,9 @@ function site_map_permission() {
+	'administer site configuration' => array(
+      'title' => t('Site map configuration'),
+    ),
  1. You cannot call the permission 'administer site configuration' because that permission is already defined by Drupal core. It should be called 'administer site map' or similar.
  2. The title should be 'Administer site map configuration' or 'Configure site map' or similar. Something that describes the action the user will get access to.
  3. Indentation needs fixing.

In addition to that, there will need to be an update function to assign the new permission to any roles that currently have the 'administer site configuration' role to avoid breaking existing sites' permissions.

sagar ramgade’s picture

sagar ramgade commented
Status: Needs work » Needs review
StatusFileSize
new sitemap-add_administration_permission-2756765-5.patch788 bytes

Hi,

I have added a permission called "Administer site map" which can be assigned to roles to administer site map. I think this should be done for D8 too.

Status: Needs review » Needs work

The last submitted patch, 5: sitemap-add_administration_permission-2756765-5.patch, failed testing.

The last submitted patch, 5: sitemap-add_administration_permission-2756765-5.patch, failed testing.

sagar ramgade’s picture

sagar ramgade commented
Status: Needs work » Needs review
StatusFileSize
new site_map-add_administration_permission-2756765-8.patch1.2 KB

It seems we need fix tests also, patch attached does that.

pareshpatel’s picture

pareshpatel commented
Assigned: Unassigned » pareshpatel
Status: Needs review » Needs work

@rooby: Thanks for your feedback.

@Sagar: Thanks for your patch but it seems that you have missed the point#3 mentioned by rooby. If any roles have already assigned "Administer site configuration" permission then they do not have access of site configuration page.

pareshpatel’s picture

pareshpatel commented
Assigned: pareshpatel » Unassigned
Status: Needs work » Needs review
StatusFileSize
new site_map-add_administration-2756765-10.patch1.75 KB

Please find the attached updated patch. Update.php must run to set the permissions for roles having "Administer site configuration".

sagar ramgade’s picture

sagar ramgade commented
Status: Needs review » Needs work

@Paresh, the comment below seems to be corrected.

+
+/**
+ * Set the configuration page permission to administer user
+ */
pareshpatel’s picture

pareshpatel commented
Status: Needs work » Needs review
StatusFileSize
new site_map-add_administration-2756765-12.patch1.8 KB

Comment has been corrected and re rolled the patch.

renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Status: Needs review » Reviewed & tested by the community
Issue tags: +ciandt-contrib
StatusFileSize
new Before.png17.84 KB
new After.png10.13 KB

Hi people.

I applied the patch and works good for me.

Before:

After:

P.s. Point in #11 was fixed.

Good Work.

Regards.

  • RenatoG committed 5427c58 on 7.x-1.x authored by pareshpatel 
    Issue #2756765 by pareshpatel, Sagar Ramgade, RenatoG, rooby: Add an...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new Before.png17.23 KB
new After.png9.74 KB

Fixed.

Commited in dev branch.

Thank you very much people.

Good Work.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.