Problem/Motivation

Facebook share is broken, twitter no share the url.

Environment:
- Drupal 8.1.3
- Sharethis beta-2

Proposed resolution

Create path absolute for every node.

Remaining tasks

Write a patch.

User interface changes

None.

CommentFileSizeAuthor
#6 sharethis_no_share_nodes-2755679-6.patch2.49 KBldavidsp
#3 sharethis_no_share_nodes-2755679-3.patch2.49 KBedysmp
#2 sharethis_no_share_nodes-2755679-2.patch594 bytesedysmp

Comments

edysmp created an issue. See original summary.

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Assigned: edysmp » Unassigned
Status: Active » Needs review
StatusFileSize
new sharethis_no_share_nodes-2755679-2.patch594 bytes
edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
StatusFileSize
new sharethis_no_share_nodes-2755679-3.patch2.49 KB

Get path with alias.

Status: Needs review » Needs work

The last submitted patch, 3: sharethis_no_share_nodes-2755679-3.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: +Needs reroll

This needs reroll after #2659250: Cannot add ShareThis field to View

ldavidsp’s picture

ldavidsp commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new sharethis_no_share_nodes-2755679-6.patch2.49 KB
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Component: Miscellaneous » Code
Status: Needs review » Reviewed & tested by the community

looks good to me.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2655010: Sharethis - 8.x-2.0-beta3

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.