I have no idea how that ended up there – it doesn't seem to have any usages (PhpStorm can find) and I also can't think of any it might have.
And even if there would be some use for it in a child class, that child class would be free to inject it itself.

So, unless someone knows a good reason, we should just remove this before beta.

CommentFileSizeAuthor
#4 remove_the_backend-2754243-4.patch1.94 KBanicky

Comments

drunken monkey created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Title: Why does the data type plugin base class have the backend manager injected » Remove the backend manager from the data type base class.

Patches that remove code are the best patches! I think this is a novice issue?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +Novice

If you also don't know a reason why that should be there, then yes.

anicky’s picture

anicky commented
Assigned: Unassigned » anicky
Status: Active » Needs review
Issue tags: +DevDaysMilan
StatusFileSize
new remove_the_backend-2754243-4.patch1.94 KB

I also searched for usages and didn't find one.

The create method remains necessary because of the implementation of ContainerFactoryPluginInterface interface.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

1 files changed, 1 insertions, 39 deletions.

So good! Thanks!

  • drunken monkey committed 6b8d8e8 on 8.x-1.x authored by Anicky 
    Issue #2754243 by Anicky: Removed the backend manager from the data type...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Yeah, looks good. Nice job, thanks!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.