Port Simpletest web tests to BrowserTestBase tests

Web tests should extend from the BrowserTestBase base class.

I don't think that's a move of all the tests? Also, it'd be great to make the patch with git diff -M > patchname.path, as that makes the patch much easier to grok.

Thanks for working on this!

Hi guys,

Checked the patch from nico comment #3 https://www.drupal.org/files/issues/initial-functional-tests-2753815-3.p...
and slightly updated it, I would like to outline some details here:

* (1) Fixed checkForMetaRefresh() method in WebTestbase - now it does as supposed to be = checks for redirects in recursion (allows to pass batches).
* (2) There is really an issue with "Index now" form, due to
<summary role="button" aria-controls="edit-index" aria-expanded="true" aria-pressed="true">Index now</summary>
this element is confusing for submitForm() method in BrowserTestBase.
$this->drupalPostForm(NULL, array(), $this->t('Index now'));
The real submit button is
<input data-drupal-selector="edit-index-now" type="submit" id="edit-index-now" name="index_now" value="Index now" class="button js-form-submit form-submit">
* (3) Ported LanguageIntegrationTest (passes 100%) and IntegrationTest , this is not final patch there are still several Tests to port.

For (2) fixed by renaming element title to "'Start indexing now". What do you think about it?

The alternative would be to pass element name into
$this->drupalPostForm(NULL, array(), 'index_now');
But it doesn't sound good as for me.

Setting to NR for the bots, will respond to #5 later.

Thanks for your help.

Updated patch includes:
CacheabilityTest
HooksTest
IntegrationTest - not finished
LanguageIntegrationTest
OverviewPageTest
ProcessorIntegrationTest

WebTestBase was renamed to SearchApiBrowserTestBase
ExampleContentTrait was moved to namespace Drupal\Tests\search_api

All search_api simpletest tests are moved to functional tests.
Current tests status:
All existing Kernel, Unit tests have passed with ../vendor/bin/phpunit

Functional tests status:
CacheabilityTest - passed
HooksTest - passed
IntegrationTest - Passed
- all things that need detail review was marked with @todo
- calls drupalPostAjaxForm - need discussing and port to javascript fucntional tests (commented now)
LanguageIntegrationTest - passed
OverviewPageTest - passed
LocalActionsWebTest - passed
ProcessorIntegrationTest - passed
ViewsTest - not passed
- need proper migration of installModulesFromClassProperty method that not exists in BrowserTestBase

1. +++ b/tests/src/Functional/IntegrationTest.php
   @@ -289,31 +295,33 @@ class IntegrationTest extends WebTestBase {
   +    // @todo Do we really need this if?
   +    if ($index instanceof IndexInterface) {
   

   Not really, we could just remove that, and the else

2. +++ b/tests/src/Functional/IntegrationTest.php
   @@ -335,20 +343,21 @@ class IntegrationTest extends WebTestBase {
   +    // @todo Commented now. need move to js fuctional tests?
   +    // $this->drupalPostAjaxForm(NULL, $edit, array('datasources_configure' => t('Configure')));
   +    // $this->drupalPostForm(NULL, $edit, $this->t('Save'));
   +    // $this->assertSession()->pageTextContains($this->t('The machine-readable name is already in use. It must be unique.'));
   

   Is there no other way to test this behavior other than a js test? That'd be very unfortunate, JS tests take a lot longer.

3. +++ b/tests/src/Functional/IntegrationTest.php
   @@ -393,32 +403,35 @@ class IntegrationTest extends WebTestBase {
   +    // @todo commented now. Need move to js tests?
   +    // $this->drupalPostAjaxForm(NULL, $edit, 'tracker_configure');
   

   See above. Not testing these would lead to a significant regression in the tests-suite as it is right now.

4. +++ b/tests/src/Functional/IntegrationTest.php
   @@ -746,24 +772,30 @@ class IntegrationTest extends WebTestBase {
   +    // @todo Do we need this if?
   +    if (!empty($fields['uid'])) {
   ...
   +    // @todo Do we need this if?
   +    if (!empty($fields['status'])) {
   

   I think we need to keep those

I'll go trough the rest of the patch after work.

I just ran the integration test locally and that did seem to pass. So not sure why the bots are so confused about this patch.

We do need to find a way to replace the drupalPostAjaxForm calls. Not sure how/if the drupal core tests have done that when they converted to BTB.

Woo - no longer errors on drupal-ci! Now all we need to do is fix the remaining fails.

Details:
- LocalActionsWebTest was marged into OverviewPageTest and removed
- @todos was processed according #13
- search_api_db test was moved to Functional
-

Drupal\Tests\search_api\ExampleContentTrait

was moved to

Drupal\Tests\search_api\Functional\ExampleContentTrait

because run-tests.sh can't preper configure autoload. It seems

drupal_phpunit_get_extension_namespaces()

not called and this issue led to CI error.
- convert arrays to short syntax

Remaining tasks:
ViewsTest - not passed
- need proper migration of installModulesFromClassProperty method that not exists in BrowserTestBase

Yeah, the autoloader is a known issue; there's a core issue available. (I don't remember the issue by heart, but I pinged @dawehner on irc to ask about that).
I'll have a look at installModulesFromClassProperty later.

installModulesFromClassProperty() migration.
It seems all simpletest tests was migrated to functional one.

modules/search_api_db/search_api_db_defaults/src/Tests/IntegrationTest.php moved to
modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php
Found strange thing with this test \Drupal\Tests\search_api_db_defaults\IntegrationTest::testInstallAndDefaultSetupWorking() is protected, not sure is it ok or not?

modules/search_api_db/tests/src/Functional/IntegrationTest.php moved to modules/search_api_db/tests/src/FunctionalJavascript/IntegrationTest.php

I think these changes look good - the diff is really big. @drunken monkey how are you feeling about these changes?