When trying to display a map with leaflet from my https protected website, I had the following problems:
* remote css and js leaflet library files could not be served from https and thus were blocked by my browser.
* when that was fixed, the tiles from OSM being called from http and not https, they were blocked by my browser.
I fixed this by switching to cloudflare's CDN and by changing the default tile source to https and that worked for me. I don't have an http environment at hand to test it so I'll share my patch and somebody can give it a try or make it better!
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | leaflet-ssl_support-2753703-2.patch | 1.66 KB | juliencarnot |
Comments
Comment #2
juliencarnot commentedComment #3
steven jones commentedMarking as needs review as we have a patch.
Comment #4
steven jones commentedThis works really nicely on both http and https. I guess maybe the module should provide an option for loading the library locally rather than using a CDN? (that would be a follow up issue)
Comment #5
acbramley commented+1 this works well, definitely agree with #4 that the module should provide a local option for serving instead of using a CDN.
Comment #6
juliencarnot commentedThanks for testing!
Feel free to open another issue about "providing an option to serve LeafletJS locally instead of from a CDN" and to reference it here so that this patch can move forward, I still haven't benchmarked both solutions to find the best performance/reliability/privacy compromise, so I don't have a strong case for this feature...
If it is a specific requirement for a project, one could always edit the leaflet.libraries.yml file to replace remote calls with a local path as a workaround.
Comment #8
pvhee commentedThanks for the patch, I've committed parts of #2 and note that the CDN support has been fixed via #2808097: Use unpkg CDN for Leaflet.
For local Leaflet library support please open a new issue!