Closed (outdated)
Project:
Drupal core
Version:
8.5.x-dev
Component:
content_moderation.module
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
22 Jun 2016 at 13:18 UTC
Updated:
1 Nov 2017 at 11:16 UTC
Jump to comment: Most recent, Most recent file



Comments
Comment #2
tkoleary commentedComment #3
tkoleary commentedComment #4
anavarreI'd vote for only adding this information in the sidebar and the reason is simple: conceptually the left column is for content and the right column is for metadata attributes.
Small change, great UX win.
Comment #5
agentrickardTraditionally the functionality described in #4 is provided by Workbench proper. In the D8 version, we still have hook_workbench_block() for that purpose.
https://github.com/agentrickard/workbench/blob/8.x-1.x/src/Plugin/Block/...
Comment #6
tkoleary commentedThat is no help to the user who does not have workbench. We should not be forcing a dependency for a basic usability feature.
Comment #7
Bojhan commentedWe shouldn't use comma's. Lets put the information under each other and style them slightly differently. I think published is less important given the state implicates it largely.
Comment #8
tkoleary commentedWhy should we not use commas?
We are already taking up a lot of vertical space and you're suggesting we take up even more?
Comment #9
mcdruid commentedMoving to core's issue queue for the content_moderation.module component.
The current moderation state is still not displayed anywhere prominent (e.g. either the title or the sidebar) in the node edit form in the latest 8.3.x-dev.
Comment #10
mcdruid commentedStarted looking at putting together a patch to add the moderation state info into the sidebar in the node edit form.
The first problem I've encountered is that the edit-meta div at the top of the sidebar:
...is actually provided by
seven_form_node_form_alter(in the seven theme).With a different admin theme (e.g. bartik), this meta info is not there:
So that's not an insurmountable problem but it means it's perhaps a little less straightforward for the content moderation module to add the moderation state information in exactly the way illustrated:
Comment #11
tkoleary commented@mcdruid
Doesn't this suggest we should open another issue to move: seven_form_node_form_alter into the node module template?
Comment #12
mcdruid commented@tkoleary - yup, that sounds reasonable.
Filed #2803875: Node form meta information should not come from a theme to work on that.
Comment #13
tkoleary commented@mcdruid
Thanks!
Comment #14
timmillwoodI think as this has currently not had any patch I'm going to make this "active" rather than "needs work". Was tempted to postpone based on #2803875: Node form meta information should not come from a theme but don't want to mute any potential discussion here.
Comment #17
sam152 commentedI wonder if this can be closed now that the moderation widget clearly indicates the current state?
Comment #18
timmillwoodThe state is now in the meta block on the right too, but this issue talks about moving it to the title / header.
Comment #19
timmillwoodWith @tkoleary not so involved with Drupal now and @Gábor Hojtsy, @jojototh, and @yoroy currently out I am going to postpone this. We can have some more discussion over the next few weeks / months and implement some improvements for 8.5.x if needed.
Comment #20
yoroy commentedDiscussed this during yesterday’s ux meeting and we think that given the current UI this is a won’t fix:
This of course still only shows the workflow state and not explicitly explains if that workflow state is a published or unpublished one. We didn't think we should want to fix that by explicitly adding that information. If this becomes a problem then people can fix that themselves by using more clear labels for the workflow state:
So we think that what we have now (which is more than what we had when this issue was opened/discussed) is sufficiently clear.
Comment #21
amateescu commentedThanks @yoroy for the update, I agree with #20 which means we can close this issue as "outdated".