Problem/Motivation

Configuration is missing for custom wrappers when you select one layout. The html output is malformed and is being printed as a normal string. (See Error.png)

When you change from "-none-" to one of the layouts, the "custom wrappers" tab doesn't appear and you can't configure it until you save the selected layout and then going to the tab. (See the sequence Config1.png, Config2.png and Config3.png)

Proposed resolution

Workaround using th UI:
Select the layout and save it. Then go to the "custom wrappers" tab and simply save the default configuration. The module presents a default configuration but it's really not saved on drupal.

With code:
In field_ui.inc set default wrapper for regions in function ds_field_ui_layouts_save.

Thanks to @nicobot for his support and his time for implementing a solution for this problem.

CommentFileSizeAuthor
#4 2752801-default-custom-wrappers-4.patch1.46 KBaspilicious
#2 2752801-default-custom-wrappers.patch749 bytesluismagr
Config3.png38.25 KBluismagr
Config2.png41.72 KBluismagr
Config1.png18.06 KBluismagr
Error.png29.77 KBluismagr

Comments

luismagr created an issue. See original summary.

luismagr’s picture

luismagr commented
StatusFileSize
new 2752801-default-custom-wrappers.patch749 bytes

Here is a patch that solve this problem for us.

luismagr’s picture

luismagr commented
Status: Active » Needs review
aspilicious’s picture

aspilicious commented
StatusFileSize
new 2752801-default-custom-wrappers-4.patch1.46 KB

Hi Luis,

Thank you for the patch!
I added a test so we can't reintroduce this again :).

Bram

  • aspilicious committed d235bda on 8.x-2.x authored by luismagr 
    Issue #2752801 by luismagr, aspilicious: Not default configuration for...
aspilicious’s picture

aspilicious commented
Status: Needs review » Fixed

Thank you again for the patch!

nicobot’s picture

nicobot commented

Hey! It's great that this went in so fast!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.