Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Heya, so I'm using Drupal Console and the Commands in this module seems like is stopping the execution of the console, as far I know they are rebuilding the way to implement the commands (they're gonna be services) so maybe is better to remove them and later on add them back.
Comment | File | Size | Author |
---|---|---|---|
#41 | metatag-remove-console-integration-2752239-41.patch | 3.5 KB | mark.labrecque |
#34 | fix_console_commands-2752239-33.patch | 4.58 KB | -enzo- |
| |||
#32 | fix_console_commands-2752239-32.patch | 4.66 KB | -enzo- |
| |||
#27 | fix_console_commands-2752239-27.patch | 8.87 KB | sylus |
| |||
#22 | metatag-n2752239-22.patch | 5.96 KB | DamienMcKenna |
|
Comments
Comment #2
Saphyel CreditAttribution: Saphyel as a volunteer commentedThis patch can also be found here: https://github.com/damienmckenna/metatag/pull/3
I didn't delete the translation because when the commands are back we don't need to revert that change
Comment #4
DamienMcKennaI'm not willing to remove the commands, I just ran one a moment ago and was able to generate a new tag plugin.
If you can show a scenario where the commands don't work with the latest version of Drupal Console and the latest stable release of Drupal core then we can try to identify the problem, but without further evidence this appears to be a-ok.
Comment #5
Saphyel CreditAttribution: Saphyel as a volunteer commentedIt doesn't matter which command you execute it's just breaking all commands.
I'm using master branch of Console because I'm helping to contribute and for me is easy to test in that way. The drupal release is not really relevant... and the problems as I said in #1 is the commands, the module works fine.
I uploaded a picture in case you don't believe me, it's fine, but yeah it happens.
The update in commands is gonna be stable sooner or later so Metatags will have to face it, someone else is going to report this again soon...
Also the title of the issue is pretty clear, it doesn't mean the functionality of the module fails or the commands are wrong
Comment #6
dazz CreditAttribution: dazz at iO commentedI have the same issue with console version 1.0.0-beta3.
Comment #7
Saphyel CreditAttribution: Saphyel as a volunteer commentedI have updated the commands to make it works with the new format, I'll upload the patch soon.
Comment #8
Saphyel CreditAttribution: Saphyel as a volunteer commentedComment #9
Saphyel CreditAttribution: Saphyel as a volunteer commentedComment #11
Saphyel CreditAttribution: Saphyel as a volunteer commentedSorry wrong patch :(
Comment #12
sylus CreditAttribution: sylus commentedI too saw this issue with latest docker console, the patch however was still giving me errors related to:
I added back that use statement and resolved that error except then I ran: generate:metatag:group and got:
Rather then the larger change of using the ContainerAwareCommandTrait and the removal of several functions including the confirmation form I just adjusted the libraries to point to their new Shared folder they were moved to and issues got resolved. I kept the translations adjustments and the docblock header removal for files ending in *.php.
For the simple trait namespacing and rename to Shared folder see: https://github.com/hechoendrupal/DrupalConsole/issues/2148
Comment #13
dazz CreditAttribution: dazz at iO commented#12 worked for me
Comment #15
DamienMcKennaClosed a duplicate: #2760661: Not compatible with Drupal Console
Comment #16
laVera CreditAttribution: laVera as a volunteer commented#12 still working. Thanks! to the maintainer: this is a big conflict, please mind it ;)
Comment #17
bdlangton CreditAttribution: bdlangton commentedI can verify that #12 works for me.
Comment #18
albertski CreditAttribution: albertski as a volunteer commented#12 works for me.
Comment #19
jamiehollernPatch in #12 works for me.
Comment #20
DamienMcKennaI reinstalled 0.11.2 and I now see the following when I run a DrupalConsole command:
Comment #21
sylus CreditAttribution: sylus commentedI believe 0.11.2 will work with the old metatag code not requiring this patch as they didn't refactor and move to the Shared folder yet.
The issue got committed on June 3rd, so just after they released v1.0.0-beta2. So this patch would be needed for anything using v1.0.0-beta3+.
https://github.com/hechoendrupal/DrupalConsole/issues/2148
Comment #22
DamienMcKennaRerolled.
Comment #23
DamienMcKennaSome changes accidentally snook into #2745177: Write tests to ensure all submodules can be enabled & all meta tags are usable:
Comment #24
DamienMcKennaNeeds work:
Comment #25
DamienMcKennaComment #26
dman CreditAttribution: dman at Sparks Interactive commentedJust a hint for others today:
As I'm not keen on patching into part of a composer-built drupal-project the team is working on this week, given that it looks like a working fix is not far off,
I found that rolling drupal/console back to 1.0.0-beta2 made the site usable again for now.
(I've got to lock drupal/console at 1.0.0-beta3 or lower anyway, due to them now requiring a higher PHP version than the deployment target server can use)
Comment #27
sylus CreditAttribution: sylus commentedI just brought back the traits and everything worked with the open graph example above for drupal console 1.0.0-beta3+ (tested against 1.0.0-beta4).
Comment #29
DamienMcKennaCommitted. Thanks.
Comment #30
OnkelTem CreditAttribution: OnkelTem commentedThe Fatal error still occurs on Drupal Console 0.11.3.
Comment #31
sylus CreditAttribution: sylus commentedPlease read #2752239-21: Fix console commands 0.11.3 wont work with newer code, please use newer then beta3
Comment #32
-enzo- CreditAttribution: -enzo- commentedI did small changes to be able to work with the latest version of Drupal Console beta5 and be prepared to work with RC1+; commands will be services
Comment #33
-enzo- CreditAttribution: -enzo- commentedComment #34
-enzo- CreditAttribution: -enzo- commentedRemoved commented code
Comment #35
heddnI've listed this as a dependency in #2741339: Plan for Metatag 8.x-1.0-beta10 release.
Comment #36
DamienMcKenna@heddn: It's already listed here as the "parent" issue, i.e. that hopefully it'll be fixed for beta10.
Could everyone please test out -enzo-'s patch and let me know if it works? Thanks.
Comment #38
DamienMcKennaCommitted.
Comment #39
giuliovale CreditAttribution: giuliovale commentedHi,
with this commit I have:
PHP Fatal error: Class 'Drupal\Console\Command\GeneratorCommand' not found in /var/www/drupal8/modules/metatag/src/Command/GenerateGroupCommand.php on line 27
Drush command terminated abnormally due to an unrecoverable error.
Error: Class 'Drupal\Console\Command\GeneratorCommand' not found in
/var/www/drupal8/modules/metatag/src/Command/GenerateGroupCommand.php,line 27
for every drush command
Comment #40
DamienMcKenna@giuliovale: Sorry about that :( I've opened #2786795: DrupalConsole integration breaks Drush and an issue on github to work on this.
Comment #41
mark.labrecqueThanks for all the efforts on getting this looked at guys. I needed to get this fixed and didn't require the integration, so I was able to just create a simple patch to remove the console integration. Thought I would provide this in case anyone else is in the same situation.
... Just until we can fix the actual problem of course :)
Comment #42
-enzo- CreditAttribution: -enzo- commented@mark.labrecque
Maybe I am wrong, but I guess did you upload the wrong patch
Comment #43
DamienMcKenna@mark.labrecque: The patch doesn't remove anything, it adds two files and adds the new services to the metatag.services.yml file.
Lets keep the "fix Drush / DrupalConsole" stuff to #2786795: DrupalConsole integration breaks Drush.
Comment #44
mark.labrecque@DamienMcKenna yeah, I just realized that I actually patched it backwards... :( I will post my corrected patch to the other issue.