To avoid future problems with syntax glitches breaking submodules, add a simple test to each submodule that ensures it can be successfully enabled.

CommentFileSizeAuthor
#13 metatag-n2745177-13.patch29.6 KBdamienmckenna
#9 metatag-n2745177-9.interdiff.txt6.32 KBdamienmckenna
#9 metatag-n2745177-9.patch27.72 KBdamienmckenna
#8 metatag-n2745177-8.interdiff.txt5.01 KBdamienmckenna
#8 metatag-n2745177-8.patch21.4 KBdamienmckenna
#7 metatag-n2745177-7.patch18.86 KBdamienmckenna
#5 write_tests_to_ensure-2745177-5.patch17.79 KBcilefen
#5 interdiff.txt1009 bytescilefen
#3 metatag-n2745177-3.patch16.41 KBdamienmckenna
#2 metatag-n2745177-2.patch4.16 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2745177-2.patch4.16 KB

Step 1: remove the submodules from the main admin tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2745177-3.patch16.41 KB

Moving things around, adding new things.

Status: Needs review » Needs work

The last submitted patch, 3: metatag-n2745177-3.patch, failed testing.

cilefen’s picture

cilefen commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1009 bytes
new write_tests_to_ensure-2745177-5.patch17.79 KB

I added a test route.

Status: Needs review » Needs work

The last submitted patch, 5: write_tests_to_ensure-2745177-5.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
Issue tags: +govcon2016
StatusFileSize
new metatag-n2745177-7.patch18.86 KB

New base class to test each meta tag.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2745177-8.patch21.4 KB
new metatag-n2745177-8.interdiff.txt5.01 KB

Added tests for the meta tags bundled with the core Metatag module. Also fixed the schema definition for the content-language meta tag.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2745177-9.patch27.72 KB
new metatag-n2745177-9.interdiff.txt6.32 KB

Tests for each of the other submodules. Also fixed schema bugs in metatag_open_graph.

  • DamienMcKenna committed 7e03acc on 8.x-1.x 
    Issue #2745177 by DamienMcKenna, cilefen: Added tests for each submodule...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks all!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Write tests to ensure all submodules can be enabled » Write tests to ensure all submodules can be enabled & all meta tags are usable
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Fixed » Patch (to be ported)

Now to backport this to D7.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new metatag-n2745177-13.patch29.6 KB

Backported.

  • DamienMcKenna committed cb79f09 on 7.x-1.x 
    Issue #2745177 by DamienMcKenna: Tests to confirm each meta tag can be...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2758749: Plan for Metatag 7.x-1.18 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.