The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.There are multiple uses of deprecated DB-functions as well as Drupal code style violations.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 2752217-16-deprecated-code-style.patch | 40.91 KB | amateichuk |
| #5 | 2752217-5-coding-style.patch | 88.95 KB | christianadamski |
| #4 | 2752217-4-coding-style.patch | 88.87 KB | christianadamski |
| #3 | 2752217-3-deprecated-code-style.patch | 6.61 KB | christianadamski |
| #2 | 2752217-2-deprecated-code-style.patch | 6.1 KB | christianadamski |
Comments
Comment #2
christianadamski commentedReplace deprecated functions and reformat code where due.
Comment #3
christianadamski commented- updated toUrl() returning Url Object instead of String
- catch exception if 'canonical' link is not set.
Will now default to frontpage, but should actually be handled before allowing this entity type to be processed in the first place.
Comment #4
christianadamski commented- fixes coding style issues across the module
- adds missing methods instead magically accessing values
- moves the batch handling mostly into the generator via static methods and removes them from .module file
Comment #5
christianadamski commented-fix in EntityForm.
Comment #14
amateescu commentedThis would be a lot easier to review if you can post multiple patches with smaller focus areas.
Comment #15
voleger#14 +1
Comment #16
amateichuk commentedReplaced some deprecated methods
Comment #17
dave reidLots of things wrong with the latest patch. Will be fixing this in #3042673: Drupal 9 Ready so marking as a duplicate.