Problem/Motivation

In views configuration every display has an admin title. For example, the frontpage view has two displays with the titles 'Page' and 'Feed'. These are configurable and are saved in the display plugin's display_title field. Page display's also have a display option called title this is saved in the display's display_options.title field. Both of these are translatable. The label in the translation form for the display_title is 'Title' and the label for the display's display_option.title is 'Display title' (lol).

As a user you are way more likely to want to translate the display_option.title field because this is way your user's see. Also there is no point in translating display_title because actually these are never used. When you edit a view you are always editing the base view - not a translated view - you edit translations on the translation page. How stopping translations of display_title will be destructive and we don't know how current sites are using it.

Proposed resolution

  1. Change display_title's label to make it clearer that it is an admin facing thing ie Display title in administration
  2. Change display_option.title's label from Display title to Title to match the UI.

Remaining tasks

User interface changes

  • display_title can not be translated
  • The title field you are likely to be looking for is not called Title and not display title.

Before

After

API changes

  • display_title can not be translated

Data model changes

None

CommentFileSizeAuthor
#30 interdiff-3_30.txt561 bytesgauravvvv
#30 2750267-30.patch1.01 KBgauravvvv
#15 Display name.png10.36 KBlendude
#14 Screen Shot 2016-07-28 at 10.14.12.png83.63 KBdawehner
#4 after.png124.81 KBalexpott
#4 before.png132.33 KBalexpott
#3 2750267-3.patch1.02 KBalexpott
#3 2-3-interdiff.txt535 bytesalexpott
#2 2750267-2.patch1.07 KBalexpott

Issue fork drupal-2750267

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2750267-2.patch1.07 KB

Something like this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Issue tags: +String change in 8.2.0
StatusFileSize
new 2-3-interdiff.txt535 bytes
new 2750267-3.patch1.02 KB 
+++ b/core/modules/views/config/schema/views.schema.yml
@@ -104,8 +104,8 @@ views.view.*:
-            type: text
...
+            type: string

Thinking about this some more... being more cautious - maybe someone is using this and using the translated versions for something. Let's not change that here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
StatusFileSize
new before.png132.33 KB
new after.png124.81 KB

Adding a before and after screenshot.

This bug is especially painful because the fieldsets are all closed to begin with so the first urge is to change the first thing you see called title.

The last submitted patch, 2: 2750267-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

These new labels makes it at least easier to understand for me! Let's see whether it doesn't fail this time.

chandeepkhosa’s picture

chandeepkhosa commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +dcbristol2016

..

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Issue tags: -Needs reroll

Looks like doesn't need to be rerolled, because git apply --check 2750267-3.patch shows nothing

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

Yep the patch applies fine to 8.2.x (it's target branch)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

I just like it. It makes things more explicit

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Translating the title of a view is harder than it should be » Labels for view title translation are unclear
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review

Thanks @alexpott and @dawehner.

Some parts of the summary seem to be out of date, so I marked them with a delete tag.

I actually find the "Display title in administration" confusing though. "Display" could be either an adjective or a verb, and it changes the meaning of the label. English--

Is it an "Administrative label"? "Administrative label for the display"? "Label to display in administration"? Etc. I've gotten confused about what is what. Screenshots of where these two title thingies are used might help too. :)

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new Screen Shot 2016-07-28 at 10.14.12.png83.63 KB

I actually find the "Display title in administration" confusing though. "Display" could be either an adjective or a verb, and it changes the meaning of the label. English--

I doubt this is an actual confusion for people, because you have the context of displays already when you read this translation form, see screenshot above.

This display title is used always in the UI, when a certain display is referred to, for example here:

https://www.drupal.org/files/issues/Screen%20Shot%202016-07-28%20at%2010...

Note: In the views UI we call this field "Administration name", but its clearly marked in the context of display

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new Display name.png10.36 KB

Instead of "Display title in administration" why not just call it 'Display name'? Thats the label that it gets in the UI (inside the dialog it's "Administration name").

It never actually gets referred to as a 'title' except in config, in the UI it's always 'name'. This way you have a clear 1-on-1 mapping as to what you are translating right?

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Category: Bug report » Task
Issue tags: - +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

This seems more like a task vs a bug.

Believe it or not the patch in #3 still applies.

Does this need to be changed to "Display name"

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 2750267-30.patch1.01 KB
new interdiff-3_30.txt561 bytes

I have updated the label 'Display title in administration' to "Display name".
Also attached inter-diff for same. Please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

If we are changing the schema believe we will need an update hook for existing sites.
Then would need a test case to verify the change has been made.

Least I know that's how new schemas are handled but would assume schema updates are the same.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.