When updating the database with drush or doing a cache clear I get:

"Error: syntax error, unexpacted '[' in .../views_slideshow/contrib/views_slideshow_cycle/views_slideshow_cycle/views_slideshow_cycle.drush.inc,
Line 13"

CommentFileSizeAuthor
#2 views_slideshow-drush-syntax-error-2749321-2.patch4.21 KBjacob.embree

Comments

spgd01 created an issue. See original summary.

jacob.embree’s picture

jacob.embree commented
Status: Active » Needs review
StatusFileSize
new views_slideshow-drush-syntax-error-2749321-2.patch4.21 KB

Versions of PHP prior to 5.4 do not support [] as syntax for creating an array.

This patch uses the old syntax for creating arrays in contrib/views_slideshow_cycle/views_slideshow_cycle.drush.inc.

Status: Needs review » Needs work

The last submitted patch, 2: views_slideshow-drush-syntax-error-2749321-2.patch, failed testing.

jacob.embree’s picture

jacob.embree commented
Status: Needs work » Needs review

There are no tested for Views Slideshow, so #2 didn't actually fail.
https://www.drupal.org/node/2645590

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

This is funny really...

I made a bug report 7 months ago and also provided the patch for it at: #2701081: PHP5.3 compatibility issue

After 2 months someone makes the identical bug report and provide the identical patch as mine but the original report gets closed as duplicate? wow.

Just saw the definition of Duplicate from Drupal books: https://www.drupal.org/node/156119#duplicate

Anyways, I don't have anything against it, I just didn't like the approach but if that's going to help solve the issue then its fine.

jacob.embree’s picture

jacob.embree commented

Yes, I don't like it either. I cringed when I found your issue and wished I had seen it first. I definitely would have marked this one as a duplicate if I had seen them both before posting my comments.

I changed the git message for this issue, so that you will get full credit for the patch. Thanks for posting a comment.

vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Reviewed & tested by the community » Fixed

As per jacob.embree request I merged the patch and credited rajibmp. Hope it is ok for everyone ;-)

Anonymous’s picture

Anonymous (not verified) commented

Thanks for the Merge... adding the patch was much more important than the credit but thanks for that one as well... Now, I can update the sites in old server without much worry. ;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.