Hi Jacob!

On the email handler page it would be very useful if we could define not only one or many recipients, but also one or many CC and BCC recipients.

Many thanks!

CommentFileSizeAuthor
#18 email_handler_cc_and-2746909-18.patch27.61 KBjrockowitz
#14 email_handler_cc_and-2746909-14.patch27.19 KBjrockowitz
#10 email_handler_cc_and-2746909-10.patch25.93 KBjrockowitz
#8 email_handler_cc_and-2746909-7.patch25.93 KBjrockowitz

Comments

Michèle created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented

Yep adding multiple recipients with CC and BCC makes sense.

jrockowitz’s picture

jrockowitz commented
Title: Email handler: CC and BCC recepients » Email handler: CC and BCC recipients

  • jrockowitz committed afa26cf on 2746909-email--handler-improvements 
    Issue #2746909: Email handler: CC and BCC recipients. Add...

  • jrockowitz committed 6f18ff9 on 2746909-email--handler-improvements 
    Issue #2746909: Email handler: CC and BCC recipients. Add...

  • jrockowitz committed 40c2f79 on 2746909-email--handler-improvements 
    Issue #2746909: Email handler: CC and BCC recipients. Add Bcc and Cc to...
jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review

Attached is a patch generated from the 2746909-email--handler-improvements branch.

I think the Bcc and Cc are setup correctly but my mail server (which is OSX/Gmail) seems to be filtering out the Bcc and Cc as SPAM.

Please test and see if the code works as expected.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new email_handler_cc_and-2746909-7.patch25.93 KB

Status: Needs review » Needs work

The last submitted patch, 8: email_handler_cc_and-2746909-7.patch, failed testing.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new email_handler_cc_and-2746909-10.patch25.93 KB

  • jrockowitz committed 3fd0c2d on 2746909-email--handler-improvements 
    Issue #2746909: Email handler: CC and BCC recipients. Fix broken test.
michèle’s picture

michèle commented

Hi Jacob

Thank you so much!
I have tested your patch. It seems to work fine and all emails are sent. I receive all mails (no spam filtering).

The only problem I see is that I can't use Tokens anymore. If I insert [yamlform-submission:values:email:raw] for example (which works fine with 8.x-1.0-beta3), I get an error message because of an invalid email address. I can't save the email handler form until I delete the token and insert a static email address.

Best regards

  • jrockowitz committed b1077b3 on 2746909-email--handler-improvements 
    Issue #2746909: Email handler: CC and BCC recipients. Add support tokens...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new email_handler_cc_and-2746909-14.patch27.19 KB

Good catch! You are now able to include tokens within the comma delimited list of email addresses.

Please test the attached patch.

michèle’s picture

michèle commented

Thank you! I have a problem testing this patch. Against beta5, I get lots of errors as well with beta3...
I will be away for a few hours and check it later again...

Status: Needs review » Needs work

The last submitted patch, 14: email_handler_cc_and-2746909-14.patch, failed testing.

jrockowitz’s picture

jrockowitz commented

Yep, the patch is broken, I will re-roll it.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new email_handler_cc_and-2746909-18.patch27.61 KB

Hopefully this works.

michèle’s picture

michèle commented

Patch #18 works perfect for me, thank you!

  • jrockowitz committed ef068be on 8.x-1.x 
    Issue #2746909 by jrockowitz: Email handler: CC and BCC recipients
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

@Michèle Thanks for filing and testing this ticket. Support multiple emails with tokens is an awesome feature.

michèle’s picture

michèle commented

You are welcome, @jrockowitz. I thank YOU for this awesome module!

michèle’s picture

michèle commented

Hey @Jacob
It seems that this patch has not already been commited to the current dev version...? Or did I miss something?

jrockowitz’s picture

jrockowitz commented

The new YamlFormEmailMultiple element is in 8.x-1.x branch.

http://cgit.drupalcode.org/yamlform/tree/src/Element/YamlFormEmailMultip...

I am also seeing the new element in the dev release.

https://www.drupal.org/project/yamlform/releases/8.x-1.x-dev

michèle’s picture

michèle commented

You are right. I see the wrong date (2016-Jun-22) besides the current dev release on the module main page and that's why I thought that the patch has not been committed. That confused me. Sorry for the inconvenience...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.