Closed (fixed)
Project:
JSON:API
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Jun 2016 at 09:37 UTC
Updated:
6 Jul 2016 at 08:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
e0ipsoComment #3
dawehnerThis is just a list of tests we should have. Whether this belongs onto the
\Drupal\jsonapi\Routing\JsonApiParamEnhancerI'm not sure. We could have an access checker, which does that kind of validation. Seems to be a bit of a better semantic place to do so.Comment #4
e0ipso+1
Comment #5
dawehnerComment #6
e0ipsoOne step closer to full compliance with the standard! Thanks @dawehner. This is almost done. I added a couple of minor suggestions.
Let's have a docblock with {@inheritdoc}'s.
Let's have a docblock with {@inheritdoc}'s.
Is there any reason not to use Drupal's base UnitTestCase?
Please add the
@covers ::accessannotationMaybe
|?Not sure if you can check those into a text file in git. Let's leave them out.
Comment #7
e0ipsoComment #8
dawehnerComment #11
e0ipsoThis looks perfect to me. We just need a re-roll.
Comment #12
e0ipsoRe-roll.
Comment #14
e0ipsoFixed and merged.
Comment #15
e0ipsoComment #16
dawehnerThank you @e0ipso!