In #2735045: Convert StandardTest to BrowserTestBase by introducing a AssertLegacyTrait and new assertions on the WebAssert the existing legacy asserts were moved to a new AssertLegacyTrait trait. The assertLink() method is currently public, but it should be protected. This is currently causing BTB tests to fail in contrib (see for example this test for Organic Groups.

All assertions in these traits are protected. The reason that this particular one is public is because it was added directly in a test class in the original issue where it was introduced #2331685: PHPUnit deprecated assertTag(), assertNotTag() and assertSelectEquals() and no attention was paid to the visibility.

CommentFileSizeAuthor
#2 2744089-2.patch602 bytespfrenssen

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review
StatusFileSize
new 2744089-2.patch602 bytes

Very curious if this will cause tests in core to fail.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue tags: +Quickfix

RTBC +1.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed aed9375 and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed 8e062e9 on 8.2.x 
    Issue #2744089 by pfrenssen: Fix visibility of AssertLegacyTrait::...

  • alexpott committed aed9375 on 8.1.x 
    Issue #2744089 by pfrenssen: Fix visibility of AssertLegacyTrait::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.