Missing argument 4 for faq_node_access() faq.module:32

on line #32 , you must change it to:

function faq_node_access(\Drupal\node\NodeInterface $node, $op, $account) {

Hi lilbebel,

I am not able to reproduce the error. Would you please provide me the steps to reproduce it?

Please make sure you are using the latest code of 8.x-1.x version.

I'm seeing this warning too, but only on the development site with the settings such that warnings get displayed, which by default is turned off in Drupal. You get this when you enable the settings.local.php and in particular the following line is making sure you get such output:

$config['system.logging']['error_level'] = 'verbose';

The full output of the error is this:

Warning: Missing argument 4 for faq_node_access() in faq_node_access() (line 32 of modules/contrib/faq/faq.module).
faq_node_access(Object, 'view', Object)
call_user_func_array('faq_node_access', Array) (Line: 402)
Drupal\Core\Extension\ModuleHandler->invokeAll('node_access', Array) (Line: 85)
Drupal\Core\Entity\EntityAccessControlHandler->access(Object, 'view', Object, 1) (Line: 68)
Drupal\node\NodeAccessControlHandler->access(Object, 'view', Object, 1) (Line: 187)
Drupal\node\Entity\Node->access('view', Object, 1) (Line: 48)
Drupal\Core\Entity\EntityAccessCheck->access(Object, Object, Object)
call_user_func_array(Array, Array) (Line: 163)
Drupal\Core\Access\AccessManager->performCheck('access_check.entity', Object) (Line: 139)
Drupal\Core\Access\AccessManager->check(Object, Object, Object, 1) (Line: 112)
Drupal\Core\Access\AccessManager->checkRequest(Object, Object, 1) (Line: 101)
Drupal\Core\Routing\AccessAwareRouter->checkAccess(Object) (Line: 86)
Drupal\Core\Routing\AccessAwareRouter->matchRequest(Object) (Line: 154)
Symfony\Component\HttpKernel\EventListener\RouterListener->onKernelRequest(Object, 'kernel.request', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.request', Object) (Line: 120)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 62)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 206)
Drupal\page_cache\StackMiddleware\PageCache->fetch(Object, 1, 1) (Line: 120)
Drupal\page_cache\StackMiddleware\PageCache->lookup(Object, 1, 1) (Line: 74)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 628)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

The comment from @livido above is quite correct and attached is a patch that does that for you. Just verify your function signature with the hook definition and you'll see that you have one argument to many.

Not sure why the test failed, can somebody help please?

+++ b/faq.module	(revision )
@@ -29,8 +29,8 @@
+function faq_node_access(\Drupal\node\NodeInterface $node, $op, $account) {

function faq_node_access(\Drupal\node\NodeInterface $node, $op, \Drupal\Core\Session\AccountInterface $account) {

Patch #6 works nice.
As per documentation though (https://api.drupal.org/api/drupal/core!modules!node!node.api.php/functio...) I would just enforce the type check on third arguments.

Patch in #10 removes the warning for me. Not sure why it failed testing again though.

Patch in #10 removes the warning for me.

Patch #10 removed the warning for me.

Hi,

I am able to reproduce the issue and patch works as expected. This can be marked as fixed.

Thanks!

@gg24, the patch should be applied and committed before. Will wait te reply from @stella.