Views More Link Target option

Thanks for the patch. Not sure this would be accepted but I took a look at the code and noticed a couple small things:

1. +++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
   @@ -1761,6 +1765,12 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   +          '#description' => $this->t("Open in new tab/window"),
   

   Would be good to simplify to 'Open in new window' and use single quotes instead of double.

2. +++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
   @@ -2090,6 +2101,10 @@ public function renderMoreLink() {
   +      if ($this->getOption('link_display_target') == true){
   

   Don't need the "== true" part.

Hi @Kristen Pol
The patch #6 not applying on Drupal version 9.1.
So I have created new patch for version 9.1 please review and there were some coding standandard issues I also fixed that.

Thanks for the update but the patch failed to apply via the testbot.

Re-rolled patch please review!

Thanks for the updates.

@Deepak Goyal and @Suresh Prabhu Parkala Please add interdiffs when you are updating patches to it's easy to see the changes, thanks: https://www.drupal.org/documentation/git/interdiff

Tried to solve failed test cases. Kindly review a patch.

@hardik patel , I m not seeing any changes in view UI when i apply the patch.
Can u provide steps to test along with expected screenshots

I don't see it either.

I found the setting.

1) This is for more than just more links. I thought it was only for more links based in the title and issue summary.

2) See the alignment issue in screenshot.

3) Even after choosing it, it's not obvious from the top level because it just says "None".

4) It didn't work for me when I changed a view (recent content) to use it. The target wasn't added.

@Hardik_Patel_12 , #22 is working as expected for more link.
Though i have made one change in the following snippet :

$form['link_display_target'] = [
          '#type' => 'checkbox',
          '#description' => $this->t("Open in new window"),
          '#default_value' => $this->getOption('link_display_target'),
        ];

as

$form['link_display_target'] = [
          '#type' => 'checkbox',
          '#title' => $this->t("Open in new window"),
          '#default_value' => $this->getOption('link_display_target'),
        ];

This will take care of the alignment issue raised by #25.

#30 works fine on checking option "open in a new tab" and then clicking on "view more" it's opening on new tab .

@amietpatial, thanks for verifying that this patch works! That is good to have recorded. There are other things that need to be done before setting an issue to RTBC. This one is tagged as needing an issue summary update, so that, at least needs to be done. There is more information about the process in the community guides, in particular reviewing patches has lots more details. One thing I like to keep in mind is that the issue should be easy for a reviewer to review and completely ready for the committer.

This is tagged as needing an issue summary update so setting to NW for that. Please add before and after screenshots to the issue summary so they can be found. And although I am not tagging this for tests due to my lack of knowledge of views, I suspect that is needed as well.