WordPressMigrationGenerator::createMigrations was originally written as the last stage of the UI, and in that context (where the user has selected from known existing entities) it can pretty much count on the passed configuration making sense. With the drush command, however, it's easy to make a typo in, say, a node bundle name, so createMigrations() should validate the incoming configurations and throw exceptions as warranted.

Issue fork wordpress_migrate-2742283

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mikeryan created an issue. See original summary.

hongpong made their first commit to this issue’s fork.

hongpong’s picture

hongpong commented

Largely covered in #3579149: Create validator classes MigrationConfigurationValidator + ValidationResult but wanted to put this onto the wizard ui final validator as well.

The validator has some services it wants in its constructor which the wizard would need to add, unless I put it somewhere else like in the generator (although the validator is called directly from inside Drush now and seems to work as we want.)

hongpong’s picture

hongpong commented
Related issues: +#3579149: Create validator classes MigrationConfigurationValidator + ValidationResult