Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Jun 2016 at 08:04 UTC
Updated:
22 Jul 2016 at 16:24 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedGit clone failed for https://git.drupal.org/sandbox/manish_nagdevani/2640946.git while invoking http://pareview.sh/pareview/httpsgitdrupalorgsandboxmanish_nagdevani2640...
Fixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
manish_nagdevani commentedComment #4
andrey.troeglazov commentedHello,
I`ve reviewed your module, there are some issues:
1) Readme file is not correct http://storage2.static.itmages.com/i/16/0617/h_1466162607_6045055_e11ec3.... Please, make it according specifications. https://www.drupal.org/node/2181737
2) You don't have hook_help. Please check it. https://www.drupal.org/node/1095546
3) Unnecessary space http://storage5.static.itmages.com/i/16/0617/h_1466162332_4282428_329da1...
http://storage7.static.itmages.com/i/16/0617/h_1466162390_2527045_95fad8...
Kind Regards.
Comment #5
andrey.troeglazov commentedComment #6
manish_nagdevani commentedComment #7
neha_patil commentedHi Manish ,
Form and its callback should be written in .inc file not in .module file, only the hooks should be in module file, rest functions should be put in .inc file and this file must be included in module.
Comment #8
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.