Critical because tests are failing in HEAD.

Apparently the friendly looking green "pass" indicators in the issue queues don't necessarily mean the tests are passing. I might be interpreting that incorrectly or set up the automated testing wrong, but the tests are definitely not passing now, as indicated here: https://www.drupal.org/pift-ci-job/302089

Comments

jmuzz created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Hi @jmuzz, I just retested on my local dev with simpletest using an older build and patch and I get what looks like similar test results that HEAD is getting, same line numbers too.

the assertion message from line 1195 field_collection.test says:

Value NULL is equal to value 'Translatable DE Mod'.

This doesn't really make much sense to me, is this what we are asserting? That Null is equal to value 'Translatable DE Mod.'?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

here's the code block from field_collection.test

     // Check that the new element is correctly saved
    $fc_item_values = $this->getFieldValues($node, $translation_langcode, $num_values);
    $this->assertEqual($fc_item_values['field_untrans'], self::UNTRANS_FIELD_DE_MOD);
    $this->assertEqual($fc_item_values['field_trans'], self::TRANS_FIELD_DE_MOD);

message we see:

Value NULL is equal to value 'Translatable DE Mod'.

The last assert in the code block above is line 1195 of field_collection.test

  • jmuzz authored 6585dca on 7.x-1.x 
    Issue #2736775 by jmuzz: Entity translation tests are failing
jmuzz’s picture

jmuzz commented
Status: Active » Fixed

I found a couple of causes:

Field collection item entities using entity translation don't appear to work correctly in a entity metadata wrapper. I changed it to use longhand fields, but this is a remaining bug.

There seemed to be the idea that field collection items should be deleted when a node's translation is deleted. This is incorrect because the same field collection items will be used for each of a node's translations. It's just their language specific field data that should be deleted with its host's translations.

jmuzz’s picture

jmuzz commented
Related issues: +#2737473: Entity translation and entity metadata wrappers

Followup.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.