Replace all calls to the deprecated Drupal::url() function in Core

Hi dbt102,

There are 483 depricated functions in drupal core.

Do we need to replace all these functions?

Well, sometimes api.drupal.org may not have the right count... But anyway, this issue is about replacing the calls to Drupal::url(), not other deprecated functions. And this issue should be marked as Active until there is a patch (see links under the Priority and Status fields for definitions). Thanks!

Replaced the deprecated function from all core files.

Test fail is due to:

PHP Parse error: syntax error, unexpected ',' in ./core/modules/field_ui/src/Tests/ManageDisplayTest.php on line 407

Hi jhodgdon,

Line 407 had incorrect implementation was Url::fromRoute(). Fixed it.

Thanks,

OK, no PHP syntax errors, but the remaining test failures look like real problems.

this replacement needs script to sed that, but using static analysis should also mention about usage in non-static class methods to follow-up with injection if required

Trying a fresh S&R against 8.8 codebase.

Fix for some places where we were collecting metadata.

Fixing more issue where the S&R put the ->toString() in the wrong spot.

Hopefully this covers the rest of the failures..

And adding the trigger error and resetting the actual test for \Drupal::url, and marking it legacy.

gah, okay, one more. At least the test is finishing..

Sat down with a coffee this morning and visually scanned the patch

All seems ok

a) I think the appropriate pattern has been used. ->toSting() where need and otherwise where not.
b) No extraneous changes.

For what it is worth, I agree with the drive behind this issue.
It is good to see so many cases of the form \Drupal:??() removed.

I bet it needs follow up to clean toString() half of places routes could be used as URL object or render type

Applied cleanly and looks consistent throughout.

I bet it needs follow up to clean toString() half of places routes could be used as URL object or render type

Probably, but for the purposes of this issue, I was not trying to change the typing. It was a string before, it's a string now., I think for the purposes of deprecation removal the direct replacement is best for a big patch like this.

Re-rolling

Re-rolling

FWIW: I agree with doing just a straight replacement by toString() in this issue.

It's very well possible that there needs to be a followup issue to handle toString() cases better, but I have the feeling that there are a lot more toString() usages in Core which need to be reviewed anyway. I've just enumerated places where I've seen toString() being used without the cacheability metadata being properly handled, in #2735575-66: Make Url::toString(TRUE) explicit by having a Url::generate() method, as well as having GeneratedUrl::toString.

(And I'm OK with creating a followup issue if I need to... after I get some idea of whether my approach to #2735575 makes sense.)

Committed/pushed to 8.8.x and cherry-picked to 8.7.x, thanks!

Sweet, great to see this in!

Closed #2699545: Replace \Drupal::l with Link::fromTextAndUrl in Link module as a duplicate of this one.