Warning: Declaration of Drupal\search_api\Plugin\views\filter\SearchApiEntityBase::operatorOptions() should be compatible with Drupal\views\Plugin\views\filter\NumericFilter::operatorOptions($which = 'title') in include() (line 12 of .../search_api/src/Plugin/views/filter/SearchApiEntityBase.php).

I'm guessing this is not actually used at the moment? Or at least doesn't have tests.

CommentFileSizeAuthor
#5 remove-file--2730031-5.patch7.18 KBborisson_
#3 2730031-3--entity_base_filter_operators.patch1.77 KBdrunken monkey

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Strict warning in Drupal\search_api\Plugin\views\filter\SearchApiEntityBas » Strict warning in Drupal\search_api\Plugin\views\filter\SearchApiEntityBase
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2730031-3--entity_base_filter_operators.patch1.77 KB

You're right, that class isn't actually used yet. Just ported as-is from D7. Maybe we should even just remove it, as long as we don't actually need it? Could at least be a pre-release task, in case we still have no use for it at that point.
Or we keep it in case other modules want to use it.

Anyways, the attached patch should repair the class again, or at least that particular bug (no telling what others there might be).

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I was using it in the old version, but actually switched away from it since I didn't need any of the features anymore. So I'm fine if you want to remove it.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new remove-file--2730031-5.patch7.18 KB

As long as nothing uses that base class, we can remove it. If it turns out that we do need this, we can always add it back.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Works for me.

  • drunken monkey committed 40a559f on 8.x-1.x 
    Issue #2730031 by drunken monkey: Fixed warnings in the Views entity...
  • drunken monkey committed eb2fa71 on 8.x-1.x authored by borisson_
    Issue #2730031 by borisson_: Removed the unused Views entity filter base...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Makes sense, yes, thanks!
Committed.
(Also committed my own patch fixing it, first, so we can restore the fixed version right away if we need it.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.