Problem/Motivation

sharethis has currently a lot of coding standard issues. We need to make it according to coding standards.

Proposed resolution

Follow: https://www.drupal.org/coding-standards documentation to make the necessary changes.

CommentFileSizeAuthor
#10 2729829-10.patch52.51 KBfelribeiro
#8 2729829-8.patch52.51 KBfelribeiro
#3 coding_standard_issues-2729829-3.patch63.55 KBnavneet0693

Comments

navneet0693 created an issue. See original summary.

navneet0693’s picture

navneet0693 commented
Issue summary: View changes
navneet0693’s picture

navneet0693 commented
Status: Active » Needs review
StatusFileSize
new coding_standard_issues-2729829-3.patch63.55 KB

Status: Needs review » Needs work

The last submitted patch, 3: coding_standard_issues-2729829-3.patch, failed testing.

navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: navneet0693 » purushotam.rai

RTBC for now but let's start fixing the coding standard issues by this patch. It can go incremental.
Thanks for initial patch!
Assigning to purushotam to give it a look

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: purushotam.rai » Unassigned
Status: Needs review » Needs work
Issue tags: +Novice, +Needs reroll

The patch does not apply anymore. This needs a reroll.

felribeiro’s picture

felribeiro commented
Status: Needs work » Needs review
StatusFileSize
new 2729829-8.patch52.51 KB

reroll the patch 3

Status: Needs review » Needs work

The last submitted patch, 8: 2729829-8.patch, failed testing.

felribeiro’s picture

felribeiro commented
Status: Needs work » Needs review
StatusFileSize
new 2729829-10.patch52.51 KB

rerolling the patch 3

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Thanks! Let's start by this by fixing the coding standards.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Coding Standard issues in sharethis » Coding Standard fixes - Round 1

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Fixed

We still have coding standard issues left. See http://pareview.sh/pareview/httpsgitdrupalorgprojectsharethisgit-7x-2x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.