Closed (fixed)
Project:
Image Effects
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 May 2016 at 17:51 UTC
Updated:
5 Dec 2016 at 10:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
andrei_khalipau commentedComment #3
slashrsm commentedLet's update the test too.
Comment #4
mondrakeFor understanding, can you please explain how you are getting to have HTML entities at this point of effect execution? Via tokens, programmatically, etc?
IMHO I think here we should be dealing with text only, with any HTML decoding/stripping done already in code upstream. If (edge case, I know) you want to actually have
"overlaid on the text, then with this you would get it converted to " anyway.For example, in Textimage, the content of a text field is passed through
strip_tagsbefore being sent to the image effect (see #2150599: Filter field text before using it to render a Textimage), so when the effect code is executed this actually manages a filtered and 'clean' text already.Comment #5
andrei_khalipau commentedI get text for overlay via tokens.
The method above returns text with encoded html entities.
You are right we do not need to convert symbols to entities back.
A patch is updated.
To slashrsm: Could you explain what is needed to update in the test? The current ImageEffectsTextOverlayTest passes.
Comment #6
mondrakeLet's do #2702205: Text overlay: add an hook to alter the overlaid text and use it to enable setting maximum number of characters displayed first, then use the hook mechanism introduced there to do this, adding an option to the effect so that users can decide if to do the decoding or not.
Comment #7
mondrakeComment #8
mondrakePatch. Introduces UI options in the Text Overlay effect config form for:
+ update functions + tests.
Comment #9
mondrakeForce conversion to bool when getting the config value from the form.
Comment #10
mondrakeTesting manually, there are schema issues when previewing the effect results.
Comment #11
mondrakeRemoved a PHP notice while previewing.
Comment #13
mondrakeCommitted.