Problem/Motivation

To reproduce:

- embed FB url (https://www.facebook.com/permalink.php?story_fbid=10153749256103892&id=8...)
- save the node
- rendered version of the FB post appears
- go to edit page
- don't change anything
- save node again
- rendered version does not appear

When Ckeditor loads on second edit it escapes "&" in the url, which then results in embed library being unable to recognize the URL.

Proposed resolution

Make sure URLs are not escaped.

CommentFileSizeAuthor
#2 2729479-2.patch617 bytesflocondetoile
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm created an issue. See original summary.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented
FileSize
2729479-2.patch617 bytes

Hi,

Here a patch that prevent double-escaping for ampersand. I'm not really "skilled" with CKEditor, and the patch seems to be a little hackish. But at least for now, embed urls are not any longer double-escaped for &.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented
Status: Active » Needs review
justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
CreditAttribution: justcaldwell as a volunteer commented

I'm unable to replicate this given the steps above. I'm guessing maybe this was an issue in CKEditor that has been fixed since the issue was originally created. Is this still an active problem, or can the issue be closed as outdated?

jjpost’s picture

jjpost CreditAttribution: jjpost as a volunteer commented

@justcaldwell The issue is still there, even in the 2.x version. This patch works for 8.1.x and 2.x.
Likely a ckeditor issue as you are suggesting, but this patch does the trick.