Just what it says in the title: If you create an index without fields (as all indexes are, initially) on a database server and then try to index, it will fail horribly. This was caused/uncovered by #2641392: Review our language/translation support, which for the first time makes it even possible to have an index without fields (for which we can/must still index data).

CommentFileSizeAuthor
#3 2729195-2--index_without_fields--tests_only.patch4.44 KBdrunken monkey
#2 2729195-2--index_without_fields.patch5.19 KBdrunken monkey
#2 2729195-2--index_without_fields--tests_only.patch4.44 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2729195-2--index_without_fields--tests_only.patch4.44 KB
new 2729195-2--index_without_fields.patch5.19 KB

The patch from #2721951-7: Search API fails to index some content unless everything is recreated, along with tests.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2729195-2--index_without_fields--tests_only.patch4.44 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2729195-2--index_without_fields--tests_only.patch, failed testing.

The last submitted patch, 3: 2729195-2--index_without_fields--tests_only.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

That code change is so simple, awesome. Test additions are also very good. Great job!

  • drunken monkey committed 7f73a61 on 8.x-1.x 
    Issue #2729195 by drunken monkey: Fixed indexes without fields on DB...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Thanks!
Committed.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Fixed » Needs work

Sorry for re-open this issue. But it breaks the Solr Backend tests. I attached the patch to fix it to #2744543: Commit of #2729195 breaks Solr backend tests.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Why re-open this issue if you created a new one anyways?

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

sorry

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.