It happens time and time again: we create a test, it fails and after half an hour of debugging we realize we just need to set our tracking_page_size config value.
Having an assertion in place for this will probably save a lot of time in the long run. (Even though it seems some of our tests are currently failing when adding it – so it's not too simple to implement, unfortunately. But maybe that means some of those tests cheat a bit in other ways, which would then be an additional advantage if we could fix that, too.)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2729193-5--content_entity_tracking_page_size_assert.patch | 9.53 KB | drunken monkey |
| #2 | 2729193-2--content_entity_tracking_page_size_assert.patch | 617 bytes | drunken monkey |
Comments
Comment #2
drunken monkeyComment #5
drunken monkeyHere is the patch with all the necessary "set config" additions to tests.
I've also added checks to only disable batches for tracking if we are actually running tests via the GUI. Don't know why we didn't do that before? (But if there's a good reason, we can of course also skip that change.)
Comment #6
borisson_This looks great! I like this very much.
Comment #8
drunken monkeyMe too, thanks for reviewing!
Committed.
Here's to hopefully numerous saved hours of needless bughunting!