Ensure that cron jobs can have services as callbacks, refactor queue worker to one

Looks like you're on track.

1. +++ b/src/CronJobDiscovery.php
   @@ -68,7 +68,7 @@ class CronJobDiscovery {
   -          'callback' => 'ultimate_cron_queue_callback',
   +          'callback' => 'ultimate_cron.queue_manager.createController',
              'scheduler' => [
   

   should be :, not .?

2. +++ b/src/QueueManagerInterface.php
   @@ -0,0 +1,19 @@
   + * @package Drupal\ultimate_cron
   + */
   +interface QueueManagerInterface {
   +
   +  public function queueCallback(CronJobInterface $job);
   +
   

   not sure if we really need an interface for this.

   Naming should be QueueWorkerInterface or so, not Manager.

Thanks, functionality looks good, needs a bit of cleanup/docs.

1. +++ b/src/Entity/CronJob.php
   @@ -7,6 +7,8 @@
    use Drupal\Core\Config\Entity\ConfigEntityBase;
   +use Drupal\Core\DependencyInjection\ClassResolver;
   +use Drupal\Core\DependencyInjection\ClassResolverInterface;
    use Drupal\Core\Entity\EntityStorageInterface;
    use Drupal\Core\Logger\RfcLogLevel;
   

   Are those actually used?

2. +++ b/src/QueueWorker.php
   @@ -0,0 +1,131 @@
   +/**
   + * @file
   + * Contains \Drupal\ultimate_cron\QueueWorker.
   + */
   

   not needed anymore.

3. +++ b/src/QueueWorker.php
   @@ -0,0 +1,131 @@
   +/**
   + * Class QueueWorker.
   + *
   + * @package Drupal\ultimate_cron
   + */
   +class QueueWorker {
   

   We don't use @package, should have an actual description.

4. +++ b/src/QueueWorker.php
   @@ -0,0 +1,131 @@
   +  /**
   +   * Drupal\Core\Queue\QueueWorkerManager definition.
   +   *
   +   * @var Drupal\Core\Queue\QueueWorkerManager
   +   */
   +  protected $plugin_manager_queue_worker;
   

   the first line seems a bit pointless, repeates the class name and it's not a definition. I personally am OK with just leaving out the description, just keep the @var. Or add a proper description like "Queue worker plugin manager". Same for those below.

5. +++ b/src/QueueWorker.php
   @@ -0,0 +1,131 @@
   +  protected $config_factory;
   +  /**
   +   * Constructor.
   +   */
   +  public function __construct(QueueWorkerManager $plugin_manager_queue_worker, QueueFactory $queue, ConfigFactory $config_factory) {
   

   missing empty line, constructurs usually have @param docs for their arguments, but I can live with them not fully defined.

6. +++ b/src/QueueWorker.php
   @@ -0,0 +1,131 @@
   +  }
   +  ¶
   +  public function queueCallback(CronJobInterface $job) {
   

   missing docblock.

7. +++ b/ultimate_cron.module
   @@ -188,89 +188,6 @@ function ultimate_cron_cron() {
    /**
   - * Cron callback for queue worker cron jobs.
   - */
   -function ultimate_cron_queue_callback(CronJobInterface $job) {
   -  $queue_name = str_replace(CronJobInterface::QUEUE_ID_PREFIX, '', $job->id());
   

   There should be some unused use statements now in this file.

Needs a reroll

Rerolled.