Update ldap_sso

1. +++ b/ldap_sso/ldap_sso.module
   @@ -5,6 +5,10 @@
   +define(DETAILED_WATCHDOG_LOG, \Drupal::config('ldap_help.settings')->get('watchdog_detail'));
   +define(AUTO_LOGIN_NO, 'do not auto login');
   +define(AUTO_LOGIN_YES, 'auto login');
   

   constants should be prefixed with the module namespace to avoid collisions. Even better, define them as class or interface constants and we can auto-load them in tests. Eg. LdapSsoInterface::NO_AUTO_LOGIN

2. +++ b/ldap_sso/ldap_sso.module
   @@ -21,26 +25,29 @@ function ldap_sso_menu() {
   +    $_SESSION['seamless_login'] = AUTO_LOGIN_NO;
   

   We should be using the session bag on the request stack, not the superglobals

3. +++ b/ldap_sso/ldap_sso.module
   @@ -21,26 +25,29 @@ function ldap_sso_menu() {
     * Implements hook_boot().
   

   hook_boot is dead, so this code won't run

4. +++ b/ldap_sso/ldap_sso.module
   @@ -51,36 +58,47 @@ function ldap_sso_boot() {
   +function _ldap_sso_boot_assume_sso_boot() {
   

   This needs a docblock

5. +++ b/ldap_sso/ldap_sso.module
   @@ -51,36 +58,47 @@ function ldap_sso_boot() {
   +  $path_args = explode('/', \Drupal::current_path());
   

   Core has a path matcher service. We should make this into a service and inject that.

6. +++ b/ldap_sso/ldap_sso.module
   @@ -51,36 +58,47 @@ function ldap_sso_boot() {
   +  } ¶
   

   trailing whitespace

7. +++ b/ldap_sso/ldap_sso.module
   @@ -51,36 +58,47 @@ function ldap_sso_boot() {
   +    require_once(DRUPAL_ROOT . '/includes/common.inc');
   +    require_once(DRUPAL_ROOT . '/includes/path.inc');
   

   Is this needed? the kernel loads these in D8

8. +++ b/ldap_sso/ldap_sso.module
   @@ -51,36 +58,47 @@ function ldap_sso_boot() {
   +      drupal_bootstrap(DRUPAL_BOOTSTRAP_LANGUAGE);
   

   drupal_bootstrap is gone too, the kernel booting does all this

9. +++ b/ldap_sso/ldap_sso.module
   @@ -220,140 +234,190 @@ function ldap_sso_user_login_sso() {
   +  drupal_goto('<front>');
   

   drupal_goto is gone too

Personally I vote ldap_sso is split into its own module and no longer part of the main ldap module on D8 - thoughts?

Assigning to @queenvictoria.

Hi @grahl.

It was our intention to remove LDAP SSO from the LDAP module. Potentially it should be reimplemented as an LDAP plugin for another SSO module (like Bakery or Connector) similar to the way LDAP Authorization works with the Authorization module.

It should probably become a sandbox module. Would you be able to create one? I'd like to git rm the module soon. So please let me know if you'd like to take it on.

Thanks!

Super thanks @grahl! Let's keep this ticket open until the code has moved. And thank you for stepping up!

I think posting an issue in the ldap_sso project asking to revive the project for d8 is a good idea. It was merged into this module in D7, but I think it should live on its own given @queenvictoria and I don't want to maintain it.

Thanks Grahl. Removing ldap_sso now.

Original owner of ldap_sso here. I unfortunately haven't thought about this module or used Drupal in several years. Grahl contacted me today - if he will be able to steward the module and it will be maintained, please take it over and port it to D8. Thanks!