Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
General code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 May 2016 at 11:40 UTC
Updated:
7 Jun 2016 at 12:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
borisson_I tagged the same issue for facets as novice, doing the same here.
Comment #3
vinay15Comment #4
vinay15Comment #5
joshi.rohit100Comment #6
joshi.rohit100Comment #7
sagar ramgade commentedThe patch attached removes FormattableMarkup from exceptions, add string within single quotes and concatenates them.
Comment #10
borisson_Fixed test + use double quotes as suggested in the IS.
Comment #13
borisson_Comment #14
drunken monkeyThanks for taking this on, nice work!
However, I spotted several small mistakes:
I'm pretty sure the
':'part there is wrong.Superfluous apostrophe.
Missing second single quote for server label.
Also, that's just my opinion, but
I'm prepared to be overvoted on both of those, though. (For the former, though, it's also a problem of consistency, since we're not doing that anywhere else in the module. (For the latter, too, really, but not so much of an argument there, I'd say.))
Comment #15
borisson_So, something like this?
Comment #16
drunken monkeyYes, better, thanks!
However, let's be consistent with using single quotes around variables, and variable substitution instead of concatenation. Patch attached.
With this, and if those changes look fine to you (and the test bot), too, this would be RTBC for me.
Comment #17
borisson_Comment #19
drunken monkeyGreat, thanks for reviewing!
Committed.
Thanks again, both of you!