First off, lovely module! A welcome alternative to some of the other social icon modules out there.
I get a JS error on public-facing pages (where the block shows);
"Uncaught TypeError: Cannot read property 'checked' of null". At issue are two lines in the update_icons() function in simple_social_icons.js which use "document.getElementById('someid')" rather than "$('#someid'). I changed these to use the $ symbol and jQuery syntax.
Also, I noticed most of the file uses jQuery, so I think this line should too. jQuery is not enabled in D8 core by default though, so there's a (albeit small) chance someone installing this module would run into JS problems due to having jQuery disabled. So, I updated the libraries YAML file to declare this dependency on jQuery.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | simple_social_icons-2725847-6.patch | 2.54 KB | n.kishorekumar |
| #3 | simple_social_icons-uncaught_type_jquery-2725847-11193783.patch | 1.45 KB | caspervoogt |
Comments
Comment #2
caspervoogt commentedHere's a patch.
Comment #3
caspervoogt commentedComment #4
n.kishorekumar commentedComment #5
n.kishorekumar commentedAfter applying this patch...
horizontal vertical tab are not working
Comment #6
n.kishorekumar commentedComment #7
heykarthikwithuComment #9
heykarthikwithuComment #11
caspervoogt commented@heykarthikwithu I'm not sure which horizontal tabs you mean, but thanks for your patch. I applied it to the 2.x-dev version, which also suffered from this issue, and it applied cleanly.
Comment #12
caspervoogt commentedjust ran into this on 3.x-dev and wrote a patch for that, using this new 3.x issue.