In the checkbox and dropdown widget, we used data-attributes to pass configuration to javascript.

Lets refactor this into using drupalSettings instead.

CommentFileSizeAuthor
#11 drupalsetting-instead-data-attribute-2725383-11.patch2.08 KBsudhanshug
#9 Use drupalSettings-2725383-9.patch2.08 KBsudhanshug
#3 facets-2725383-use-js-setting-for-widget.patch2.04 KBdragos-dumi

Comments

StryKaizer created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue tags: +Novice
dragos-dumi’s picture

dragos-dumi commented
StatusFileSize
new facets-2725383-use-js-setting-for-widget.patch2.04 KB

There is only one setting in dropdown widget being passed from plugin class to js using data attributes.

dragos-dumi’s picture

dragos-dumi commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

I just did a quick review in my phone and it looks good. Setting to rtbc for now. I'll have another look at the airport.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Looks great, thanks @dragos-dumi.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented

Can be committed after manual test on dropdown widget

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue tags: +Needs reroll

I wanted to manually test this before commit, but it not longer applies.

sudhanshug’s picture

sudhanshug commented
StatusFileSize
new Use drupalSettings-2725383-9.patch2.08 KB

Re-rolled the patch from #3

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: Use drupalSettings-2725383-9.patch, failed testing.

sudhanshug’s picture

sudhanshug commented
StatusFileSize
new drupalsetting-instead-data-attribute-2725383-11.patch2.08 KB

Sorry for #9, here is the patch with a valid name.

sudhanshug’s picture

sudhanshug commented
Status: Needs work » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Fixed

Manually tested, committed and pushed. Thanks for the reroll @sudhanshug and thanks for all the patience @dragos-dumi.

  • borisson_ committed 1c1588c on 8.x-1.x authored by dragos-dumi 
    Issue #2725383 by sudhanshug, dragos-dumi: Use drupalSettings instead of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.