Closed (fixed)
Project:
Drupal core
Version:
8.1.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
13 May 2016 at 08:22 UTC
Updated:
6 Jun 2016 at 11:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
cilefen commentedYes, it does need changing.
Comment #3
jhodgdonRemoving extraneous tags, and adding Novice tag. Also fixing version.
Comment #4
snehi commentedUploading first patch for this issue.
Comment #5
jhodgdonThanks! This is a good start. A few thoughts:
We use American spellings in Drupal files, so "favorite". Actually though, let's not say "your favorite editor", but "a plain-text editor".
missing "the" before "following". Also see above about uncomment.
Comment #6
Sonal.Sangale commentedComment #7
Sonal.Sangale commentedModifications are added as per the suggestions.
There are many ways to write the directory structure as per the documentation. Which way should be used in documentation?
Comment #8
jhodgdonThanks, looking better!
needs a space before (
This is a paragraph break. Needs a blank line between the paragraphs. Also in the second line here, needs a space before the (
Can you make this into a complete sentence?
Comment #9
snehi commentedDone.
Comment #10
jhodgdonLooks great! One small thing:
Can we add 'and save the file' to this sentence too? Because as the patch is now, the only place it says to save the file is in the part about private files. So we should say it here too (either that or assume people would know to save the file and omit it in both places?) (probably saying "save the file" is fine though, but let's be consistent and do it in both places).
Comment #11
pushpinderchauhan commentedIncorporated suggested changes.
Comment #12
snehi commentedNow i think all the suggestions and corrections given by @jhodgdon in #5 , #8 and #10 are incorporated.
So making this RTBC.
Comment #13
jhodgdonLooks good to me too, thanks!
Comment #15
ashishdalviLooks like. Patch failing is due to unrelated reason. https://www.drupal.org/node/2724871
Changing status to RTBC as per previous comment.
Comment #17
catchCommitted/pushed to 8.2.x, thanks!
Comment #19
catchAnd cherry-picked to 8.1.x...