[D8] Google CSE

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi immanuel.paul,

Please recheck some points with standards :

1: Do not use tab in gcs.html.twig

{% if title %}
	<h2>{{ title }}</h2>
{% endif %}
<gcse:searchbox></gcse:searchbox>
<gcse:searchresults></gcse:searchresults>
<div id="gcs-results"></div>

2: Follow the Readme template for the README.txt https://www.drupal.org/node/2181737

@immanuel.paul,
Collaborate with the google_cse module author and push the d8 code into the existing module and apply for the review here.
We always encourage collaboration over competition.

small overview of code :

• gcs.info.yml : why you set the hidden: false ?
• gcs.install : gcs_install is not needed if you want to set default values then provide default values in config/install directory . gcs_uninstall is not needed configuration will be automatically removed as the module gets uninstalled.
• Add a hook_help in .module file.
• Why restrict access on administer permission in .permissions.yml file.
• GcsAdminForm : use DI to inject the configfactory service
• GcsForm : use DI to inject the configfactory service
• Define the schema/metadata information of the configuration you are using in module https://www.drupal.org/node/1905070
• GcsBlock : Use DI(Dependency Injection) to inject the Form builder service.
• GcsController : Use DI(Dependency Injection) here.
• The search would not work if the Google Custom Search Engine ID would not be set. So add a hook_requirements for it and throw a run time exception on status page. that key is not set.

any reason of not merging efforts with the current Google CSE module, and the current issue to port it to D8?

https://www.drupal.org/node/2387189

Hi @immanuel,

thanks for your answer.

I understand, but given that D8 codebase version is just starting, this should be a patch/contribution to the main module, instead of adding duplication creating a module that does the same thing (lighter or not).

In other words, I think this not meet the point 1.2 of the PA checklist: https://www.drupal.org/node/1587704

1.2 Ensure your project is not a duplication.

why not joining forces ;-) ? I don't see any reason why you could not be promoted to contributor and help there, although I'm not sure how to do it outside of the normal project application workflow.

That's exactly a duplication (actually 3x) of efforts