If this gets merged; https://www.drupal.org/node/2682585 we're going to need to rename to MigrationConfigurationTrait.

CommentFileSizeAuthor
#2 2723535-2.patch656 byteswillwh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willwh created an issue. See original summary.

willwh’s picture

FileSize
656 bytes

and here's a patch...

dscl’s picture

Assigned: willwh » Unassigned

If we assume people will be using the latest core version, we can do it now since that ticket got committed and shipped into 8.1.3.
But changing it would break the module for anyone using a core version < 8.1.3.

And the final patch for that ticket kept the MigrationCreationTrait in and deprecated it, so changing it isn't *immediately* required.
Maybe we can postpone it. Not sure.

mikeryan’s picture

There'll be non-BC-maintaining changes coming for 8.2.x (in particular, #2695297: Refactor EntityFile and use process plugins instead) that will affect migrate_upgrade. So, my plan is to have an 8.x-2.0 release which only supports core 8.1.x (and keeps using MigrationCreationTrait), and open a new 8.x-3.x branch to support core 8.2.x and up - this patch will go into that branch. I'm putting off branching until I have to (i.e., when there's a BC breaker like the EntityFile change).

  • mikeryan committed 3d9a904 on 8.x-3.x authored by willwh
    Issue #2723535 by willwh: Rename MigrationCreationTrait
    
mikeryan’s picture

Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Active » Fixed

Now that we have the 8.2.x-compatible branch, committed - thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.