FacetSourceEditForm inherits from EntityForm, but that doesn't take care of either showing the user a message, or returning them to their starting page on save.

CommentFileSizeAuthor
#6 facetsourceeditform-2723405-6.patch1.84 KBstrykaizer
#3 facetsourceeditform-2723405-3.patch683 bytesstrykaizer

Comments

joachim created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue tags: +Novice

The FacetSourceEditForm should implement the submitForm method. That method should call parent::submitForm and add a message that the entity was updated.

The FacetSourceTest can be extended to check for that message as well as assertResponse(200) that's currently there.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Active » Needs review
StatusFileSize
new facetsourceeditform-2723405-3.patch683 bytes

Status: Needs review » Needs work

The last submitted patch, 3: facetsourceeditform-2723405-3.patch, failed testing.

The last submitted patch, 3: facetsourceeditform-2723405-3.patch, failed testing.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new facetsourceeditform-2723405-6.patch1.84 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

  • borisson_ committed 30146cf on 8.x-1.x authored by StryKaizer 
    Issue #2723405 by StryKaizer: FacetSourceEditForm doesn't redirect to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.