CommentFileSizeAuthor
#2 add_readme_md_to_the-2722745-2.patch1.13 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new add_readme_md_to_the-2722745-2.patch1.13 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

File can be viewed here. https://github.com/jibran/dynamic_entity_reference/blob/3d8638ac6b0e26df...

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work 
+++ b/README.md
@@ -0,0 +1,15 @@
+Development being undertaken by [@larowlan](https://www.drupal.org/u/larowlan) and [@jibran](https://www.drupal.org/u/jibran) of [PreviousNext](https://www.drupal.org/marketplace/previousnext)

This is wrong, you should be named first.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Fixed

Your name is first because you are the author of the module.

  • jibran committed 947a1f4 on 8.x-1.x 
    Issue #2722745 by jibran: Add README.md to the module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.