Posting this issue as a follow-up of #2717103: Removing @file docblocks.

Problem/Motivation

According to the @file doc standard coding, we should dropped all @file path documentation for classes / interfaces / traits. Plus it would be better to commit refactoring and other non-/functional clean-up fixes as a combined patch.

Proposed resolution

- refactor docblocks
- inspect code for Redirect module
- upload the patch

CommentFileSizeAuthor
#7 interdiff-2722391-4-7.txt3.87 KBginovski
#7 general-refactoring-27722391-7.patch81.45 KBginovski
#4 general-refactoring-2722391-4.patch79.47 KBginovski

Comments

Bambell created an issue. See original summary.

Bambell’s picture

Bambell commented
Issue summary: View changes
ginovski’s picture

ginovski commented
Assigned: Unassigned » ginovski
ginovski’s picture

ginovski commented
StatusFileSize
new general-refactoring-2722391-4.patch79.47 KB
ginovski’s picture

ginovski commented
Status: Active » Needs review
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs review » Needs work

As discussed please fix the pointed variables names.

ginovski’s picture

ginovski commented
Status: Needs work » Needs review
StatusFileSize
new general-refactoring-27722391-7.patch81.45 KB
new interdiff-2722391-4-7.txt3.87 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: General refactoring from Redirect inspection » General code style cleanup from Redirect inspection

This is not refactoring ;)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Postponed

Sorry but this is not important enough to break other issues that are making big and more important changes. Possibly later when things settled down and we have a beta.