Over in Facet's results sorting with multiple sorts., @claudiu.cristea mentioned that we should trigger as little code as possible when throwing an exception. So in our current code, everywhere we call $this-t() or new FormattableMarkup when throwing an exception, that should be fixed with the string in double quotes and the string injected in {}.

This might mean that we can updated some of our tests as well.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

mr.baileys’s picture

Assigned: Unassigned » mr.baileys
mr.baileys’s picture

Status: Active » Needs review
FileSize
2.6 KB
borisson_’s picture

Assigned: mr.baileys » Unassigned
Status: Needs review » Reviewed & tested by the community

Awesome. Thanks!

  • borisson_ committed e965b98 on 8.x-1.x authored by mr.baileys
    Issue #2722271 by mr.baileys: Make sure as little code as possible is...
borisson_’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.