Over in Facet's results sorting with multiple sorts., @claudiu.cristea mentioned that we should trigger as little code as possible when throwing an exception. So in our current code, everywhere we call $this-t() or new FormattableMarkup when throwing an exception, that should be fixed with the string in double quotes and the string injected in {}.
This might mean that we can updated some of our tests as well.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | make_sure_as_little-2722271-3.patch | 2.6 KB | mr.baileys |
Comments
Comment #2
mr.baileysComment #3
mr.baileysComment #4
borisson_Awesome. Thanks!
Comment #6
borisson_Thanks!