In #2656668: Facet's results sorting with multiple sorts., @StryKaizer noticed that Facet::getProcessorsByStage doesn't return the correct processor configuration.

The real issue was that we initiate another instance, while we should use the instances as returned by getProcessorsByStage. This will be fixxed in #2724171: Create a new processor stage 'Sort'.

This issue refactors the getProcessorsByStage implementation to reuse getProcessors do reduce duplicate code.

Files: 

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

Category: Task » Bug report

This is a bug, not a task.

StryKaizer’s picture

Status: Active » Needs review
FileSize
2.78 KB

It looks like getProcessorsByStage does return the correct configuration, but on the next line we created a new instance, which is not required, as getProcessorsByStage already returns instances.

Refactored code a bit and fixxed this.

This patch will need a reroll once #2724171: Create a new processor stage 'Sort' is in

StryKaizer’s picture

Decided to fix the actual issue in #2724171: Create a new processor stage 'Sort' instead, this patch contains only the refactor in Facet.php to re-use loadProcessors now, and does no longer needs to be rerolled depending on #2724171

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

borisson_’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.