1. Selecting no interval type and numeric value filled - No error message
2. Non numeric value - "You must enter a numeric value" (for what field??)

Picture attached show two errors from a form submission.
First error is from a regular integer field.
Second error is from an interval field.

I have applied patch from https://www.drupal.org/node/2352491.

CommentFileSizeAuthor
#10 vagueErrorMessages-2721765-10.patch1.15 KBmonstrfolk
#9 vagueErrorMessages-2721765-9.patch1.15 KBmonstrfolk
#3 vagueErrorMessages-2721765-3.patch1.15 KBmonstrfolk
Screen Shot 2016-05-09 at 11.00.54 AM.png16.65 KBmonstrfolk

Comments

monstrfolk created an issue. See original summary.

monstrfolk’s picture

monstrfolk commented
Issue summary: View changes
monstrfolk’s picture

monstrfolk commented
StatusFileSize
new vagueErrorMessages-2721765-3.patch1.15 KB

Created patch to correct both vague messages. This patched is combined with https://www.drupal.org/node/2352491.

monstrfolk’s picture

monstrfolk commented
Status: Active » Needs review
monstrfolk’s picture

monstrfolk commented
Title: Error messages are very vague. » Improve error messages for forms.
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented 
+++ b/interval.module
@@ -77,7 +77,13 @@ function interval_field_validate($entity_type, $entity, $field, $instance, $lang
+          'message' => t('Must set time period for %name.', array('%name' => $instance['label'])),

Suggest 'You must select a time period for ...' instead? Thoughts?

Other than that minor wording, looks good to me.

monstrfolk’s picture

monstrfolk commented

Other fields do not have you. Something without "you" perhaps.

How about..."Time period is required for ..."?

monstrfolk’s picture

monstrfolk commented

I can recreate the patch with different wording to get it submitted.

monstrfolk’s picture

monstrfolk commented
StatusFileSize
new vagueErrorMessages-2721765-9.patch1.15 KB

wording change

monstrfolk’s picture

monstrfolk commented
StatusFileSize
new vagueErrorMessages-2721765-10.patch1.15 KB

Can this be committed please?

Status: Needs review » Needs work

The last submitted patch, 10: vagueErrorMessages-2721765-10.patch, failed testing.

monstrfolk’s picture

monstrfolk commented
Status: Needs work » Needs review

patch is good