Just a small DX improvement: the docblock for SearchApiRow could do to add a '@see search_api_views_plugins_row_alter().', since that sets the 'base' property for the plugin dynamically. Would have saved me some digging and probably will do for other people in the future.

CommentFileSizeAuthor
#16 add-at-see.patch521 bytesborisson_
#10 search_api-add-a-@see-to-SearchApiRow-2721631-3-9.patch521 bytesmcgovernm
#3 search_api-add-a-@see-to-SearchApiRow-2721631-3-8.patch522 bytesvinay15

Comments

joachim created an issue. See original summary.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Assigned: Unassigned » vinay15
vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
StatusFileSize
new search_api-add-a-@see-to-SearchApiRow-2721631-3-8.patch522 bytes

Added @see.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: search_api-add-a-@see-to-SearchApiRow-2721631-3-8.patch, failed testing.

The last submitted patch, 3: search_api-add-a-@see-to-SearchApiRow-2721631-3-8.patch, failed testing.

The last submitted patch, 3: search_api-add-a-@see-to-SearchApiRow-2721631-3-8.patch, failed testing.

The last submitted patch, 3: search_api-add-a-@see-to-SearchApiRow-2721631-3-8.patch, failed testing.

mcgovernm’s picture

mcgovernm commented

I'll be taking a look at this patch at Drupalcon New Orleans, today.

mcgovernm’s picture

mcgovernm commented
StatusFileSize
new search_api-add-a-@see-to-SearchApiRow-2721631-3-9.patch521 bytes
mcgovernm’s picture

mcgovernm commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: search_api-add-a-@see-to-SearchApiRow-2721631-3-9.patch, failed testing.

The last submitted patch, 10: search_api-add-a-@see-to-SearchApiRow-2721631-3-9.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

The patch file can't have an '@' in it, looks like. You should rename the file so the testbot can apply it?

mcgovernm’s picture

mcgovernm commented

I looked through the @see comments in core, none of them had a period at the end of the comment, so I removed the period from the patch and uploaded it again. It failed testing again. I'm thinking it may be an issue with test bot.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new add-at-see.patch521 bytes
mcgovernm’s picture

mcgovernm commented
Status: Needs review » Reviewed & tested by the community

This looks good! Thanks borisson_, you beat me to it!

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented

Thank you guys!! I will keep this in mind.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Seems it's due to the escape sequence in the URL? Anyways, that's news to me, too. Interesting to know.
(Maybe we should create a DrupalCI issue for this?)

Anyways, the patch itself looks great, of course – thanks!

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.