The default size of form select boxes makes the Data sources form element hard to use. You can't see which sources are enabled at a glance, and there's a risk of accidentally clicking one as you scroll.

In this issue, we should change the select box to checkboxes.

CommentFileSizeAuthor
#15 2721553-15--datasources_checkboxes.patch5.11 KBdrunken monkey
#15 2721553-15--datasources_checkboxes--interdiff.txt938 bytesdrunken monkey
#13 screenshot.png41.34 KBsakthivel m
#2 2721553-2.search_api.data-source-select-size.patch497 bytesjoachim
#7 2721553-7.search_api.data-source-select-size.patch1.05 KBjoachim
#11 search_api-change_datasources_to_checkboxes-2721553-11.patch4.39 KBalan-ps
#11 interdiff-2721553-7-11.txt3.26 KBalan-ps

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2721553-2.search_api.data-source-select-size.patch497 bytes
joachim’s picture

joachim commented
Parent issue: » #2471184: Suggestions for improving the Search API admin UI for the Add/Edit Index screen

Just seen #2471184: Suggestions for improving the Search API admin UI for the Add/Edit Index screen, where it's suggested to change this to checkboxes.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

I think I prefer that solution as well, shall we close this issue and start working on that one?

joachim’s picture

joachim commented

Fair enough.

Or change the title of this & set it to needs work? That other issue is a meta-issue, so we'd still need one for changing this form element.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Title: increase the size of the Data sources select box » Change the "data sources" select box to checkboxes
Issue summary: View changes
Status: Needs review » Needs work

Yeah, that makes more sense. I did that.

joachim’s picture

joachim commented
Status: Needs work » Needs review
StatusFileSize
new 2721553-7.search_api.data-source-select-size.patch1.05 KB

Status: Needs review » Needs work

The last submitted patch, 7: 2721553-7.search_api.data-source-select-size.patch, failed testing.

The last submitted patch, 7: 2721553-7.search_api.data-source-select-size.patch, failed testing.

The last submitted patch, 7: 2721553-7.search_api.data-source-select-size.patch, failed testing.

alan-ps’s picture

alan-ps commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2721553-7-11.txt3.26 KB
new search_api-change_datasources_to_checkboxes-2721553-11.patch4.39 KB

Looks like we should update test cases as well.

The last submitted patch, 11: search_api-change_datasources_to_checkboxes-2721553-11.patch, failed testing.

sakthivel m’s picture

sakthivel m commented
StatusFileSize
new screenshot.png41.34 KB

Hi,

I tested patch #11 its works fine and show as per our requirement.

But dont know the reason of fail in auto testing.
screenshot

Thanks,
Sakthi

alan-ps’s picture

alan-ps commented

Looks like all test cases passed after retesting.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2721553-15--datasources_checkboxes--interdiff.txt938 bytes
new 2721553-15--datasources_checkboxes.patch5.11 KB

Looks pretty good, thanks a lot!
However, I think we should also add the search-api-checkboxes-list class, so it doesn't take up too much space if there are lots of datasources available.
Are you OK with that change? Then I can commit.

In any case, thanks again!

alan-ps’s picture

alan-ps commented

Yes, it makes sense. I fully agree with it.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

OK, great! Committed.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.