Problem/Motivation

YAML form module is going to need to start providing some addition all form elements like a likert widget.

Proposed resolution

Cleanup YAML form element plugin and make CodeMirror integration a reusable element.

Remaining tasks

  • Update YamlFormElementListBuilder
  • Create 'yamlform_code' element
  • Setup examples
  • Update codemirror instances.
  • Update tests

User interface changes

Display all available elements in YamlFormListBuilder

API changes

  • Added YamlFormElementManagerInterface
  • Added YamlFormHandlerManagerInterface

Development Notes

  • Branch Name: 2719007-refactor-elements
  • Patch Name: yamlform-refactor-elements-2719007-XX.patch
  • Commit message: Issue #2719007: Refactor YamlFormElement and CodeMirror element.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

Issue summary: View changes
jrockowitz’s picture

Issue summary: View changes

  • jrockowitz committed 0131ed4 on 2719007-refactor-elements
    Issue #2719007: Refactor YamlFormElement and CodeMirror element.
    

  • jrockowitz committed 3988f89 on 2719007-refactor-elements
    Issue #2719007: Refactor YamlFormElement and CodeMirror element. Bug...
jrockowitz’s picture

jrockowitz’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: yamlform-refactor-elements-2719007-06.patch, failed testing.

jrockowitz’s picture

Status: Needs work » Needs review
FileSize
83.41 KB

  • jrockowitz committed 0131ed4 on 8.x-1.x
    Issue #2719007: Refactor YamlFormElement and CodeMirror element.
    
  • jrockowitz committed 3988f89 on 8.x-1.x
    Issue #2719007: Refactor YamlFormElement and CodeMirror element. Bug...
jrockowitz’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.