When 'site_mail' variable is not empty, it always override 'From' header

CommentFileSizeAuthor
#18 2714749-17.patch656 bytesdawehner
#17 2714749-17.patch997 bytesdawehner
#15 2714749-15.patch610 bytesdawehner
#12 site_mail_variable-2714749-12.patch1.54 KBnileshlohar
#10 site_mail_variable-2714749-10.patch1.5 KBnileshlohar
#8 smtp-site_mail_overrides_from_header-2714749-8.patch2.04 KBdbiscalchin
#5 smtp-site_mail_overrides_from_header-2714749-5.patch1.02 KBtheterencechan
#2 smtp-site_mail_overrides_from_header-2714749-2-7.x-2.x.patch697 byteshenrikenji

Comments

henrikenji created an issue. See original summary.

henrikenji’s picture

henrikenji commented
StatusFileSize
new smtp-site_mail_overrides_from_header-2714749-2-7.x-2.x.patch697 bytes

Just removed the code that forced to 'site_mail' variable to be always 'From' header

henrikenji’s picture

henrikenji commented
Status: Active » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Is this a (partial) duplicate of #1686588: Use From address properly?

theterencechan’s picture

theterencechan commented
StatusFileSize
new smtp-site_mail_overrides_from_header-2714749-5.patch1.02 KB

With patch #2, for my webform, the site email become the email address for "on behalf of" my from email address in my webform. I added a sender header to get rid of this as well. The patch was created for the 7.x-1.x version.

djpable’s picture

djpable commented

I think that the correct "From" string should be $from_name that is now unused in mailWithoutQueue() method....

Simplenews
Mime Mail
Mail System
Smtp Authentication
Drupal 7.52

stack is really broken after 7.50 update and Smtp Authentication support 1.4 !!

dbiscalchin’s picture

dbiscalchin commented
Status: Needs review » Needs work

Moving to "Needs work", because both "Sender" and "Return-Path" headers should be set to the "From" value provided in the module settings.

dbiscalchin’s picture

dbiscalchin commented
StatusFileSize
new smtp-site_mail_overrides_from_header-2714749-8.patch2.04 KB

This patch fixes both "Sender" and "Return-Path" headers. It works on 2.x branch.

I've also removed some code that apparently would never be reached, because $from couldn't be empty at that point.

dbiscalchin’s picture

dbiscalchin commented
Status: Needs work » Needs review
nileshlohar’s picture

nileshlohar commented
StatusFileSize
new site_mail_variable-2714749-10.patch1.5 KB

Patch for the latest release.

Status: Needs review » Needs work

The last submitted patch, 10: site_mail_variable-2714749-10.patch, failed testing.

nileshlohar’s picture

nileshlohar commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
StatusFileSize
new site_mail_variable-2714749-12.patch1.54 KB

Re-rolling it.

jrochate’s picture

jrochate commented

Thanks! 7.x-1.x patch works flawless.

jrochate’s picture

jrochate commented

Well, actually I found that From: is being sent twice on mail headers.

So, some ISP are considering it as non-RFC a rejecting mail (google does).

Had to revert patch, since I didn't find with line was wrong.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2714749-15.patch610 bytes

Here is a patch which seemed to do something similar in D8.

Status: Needs review » Needs work

The last submitted patch, 15: 2714749-15.patch, failed testing. View results

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2714749-17.patch997 bytes

This still had issues with the 'Sender' header.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2714749-17.patch656 bytes

Oops, it contained the .patch file.

andypost’s picture

andypost
he/him
Primary language Russian
commented

This is duplicate of #1686588: Use From address properly

bluegeek9’s picture

bluegeek9 commented
Assigned: henrikenji » Unassigned
Status: Needs work » Closed (outdated)
//www.flaticon.com/free-icons/thank-you Thank you for your contribution!

Unfortunatly, Drupal 7 is End of Life and no longer supported. We strondly encourage you to upgrade to a supported version of Drupal.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.